Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate nexus-e2e with Nexus GitHub workflow #120

Closed
homura opened this issue Mar 13, 2023 · 3 comments · Fixed by #184
Closed

Integrate nexus-e2e with Nexus GitHub workflow #120

homura opened this issue Mar 13, 2023 · 3 comments · Fixed by #184
Labels
released This issue/pull request has been released.
Milestone
2023W11

Comments

@homura
Copy link
Contributor

homura commented Mar 13, 2023 •
edited
Loading

https://github.com/gpBlockchain/nexus-e2e/blob/main/packages/e2e/README.md

  • option 1 - git submodule, import nexus-e2e as a git submodule
  • option 2 - workspace, import it as a sub package
@homura homura added this to the 2023W11 milestone Mar 13, 2023
@homura homura mentioned this issue Mar 27, 2023
Closed
4 tasks
@IronLu233
Copy link
Contributor

#151

@homura
Copy link
Contributor Author

homura commented Apr 3, 2023 •
edited
Loading

after discussion, we decided to refactor the existing e2e tests in order to make e2e more maintainable

In Short

  • deprecate unnecessary data-testid
  • a ckb object that can run in Node.js
  • one file, one scenario

@homura homura mentioned this issue Apr 10, 2023
Merged
4 tasks
@github-actions
Copy link

🚀 Issue was released in v0.0.11 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
2023W11
Development

Successfully merging a pull request may close this issue.

test: e2e test scaffolding ckb-js/nexus
test: add e2e test gpBlockchain/nexus
2 participants
@homura @IronLu233