Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for k70 pro #1030

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add support for k70 pro #1030

wants to merge 2 commits into from

Conversation

c4181
Copy link

@c4181 c4181 commented Jan 9, 2024

Adds support for the K70 RGB Pro (1bb3)

All the LEDs are working except the logo light. If there are ideas about how to get the logo light working I'm happy to make the change and test Fixed with @JohnoKing's patch.

closes #865
closes #915
closes #928
closes #998

@JohnoKing
Copy link

I managed to get the logo light working by changing the mapping to use 'topbar1'. Patch:

diff --git a/src/gui/keymap.cpp b/src/gui/keymap.cpp
index f06de56..a653ef1 100644
--- a/src/gui/keymap.cpp
+++ b/src/gui/keymap.cpp
@@ -887,7 +887,7 @@ static QHash<QString, Key> getMap(KeyMap::Model model, KeyMap::Layout layout){
         map["volup"].x += 10;
         map["voldn"].x += 10;
 
-        map["logo"] = {nullptr, "Logo", "logo", 128, 0, NS, true, false};
+        map["topbar1"] = {nullptr, "Logo", "topbar1", 128, 0, NS, true, false};
         map.remove("m3");
         map.remove("g11");
 

@c4181
Copy link
Author

c4181 commented Feb 9, 2024

@JohnoKing That's awesome! I added the patch to the PR.

@edg-l
Copy link

edg-l commented Mar 4, 2024

i confirmed this works on my k70 pro

The daemon had a warning tho

❯ sudo ckb-next-daemon
ckb-next-daemon 0.6.0-35-g973fa23
[I] Root controller ready at /dev/input/ckb0
[I] Connecting CORSAIR K70 RGB PRO Mechanical Gaming Keyboard at /dev/input/ckb1
[I] Starting input thread for /dev/input/ckb1
[I] Found EP 0x81 at /sys/devices/pci0000:00/0000:00:01.2/0000:05:00.0/usb1/1-5/1-5:1.0/ep_81
[I] Found EP 0x82 at /sys/devices/pci0000:00/0000:00:01.2/0000:05:00.0/usb1/1-5/1-5:1.1/ep_82
[I] Found EP 0x83 at /sys/devices/pci0000:00/0000:00:01.2/0000:05:00.0/usb1/1-5/1-5:1.2/ep_83
[W] bragi_get_property (bragi_common.c:13): Failed to get property 0x15. Device said it's not supported.
[W] bragi_get_property (bragi_common.c:13): Failed to get property 0x16. Device said it's not supported.
[I] Setup finished for /dev/input/ckb1
[E] bragi_open_handle (bragi_common.c:193): Failed to open handle 0x0. Error was 0x1
[W] setactive_bragi (device_bragi.c:96): ckb1: Bragi light init returned not supported

@sim51
Copy link

sim51 commented Apr 3, 2024

Same here, it works on mine, thanks !

@Helladen
Copy link
Contributor

Helladen commented May 18, 2024

This works for me.
image

@DreiPixel DreiPixel mentioned this pull request Aug 24, 2024
@Kobi-Dadon
Copy link

This works for me. image

How can i install this PR version? i tried compiling it but no success :/
merging this would be awesome but i guess we'll have to wait for this to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants