-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for k70 pro #1030
Open
c4181
wants to merge
2
commits into
ckb-next:master
Choose a base branch
from
c4181:k70-pro
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add support for k70 pro #1030
+49
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I managed to get the logo light working by changing the mapping to use 'topbar1'. Patch: diff --git a/src/gui/keymap.cpp b/src/gui/keymap.cpp
index f06de56..a653ef1 100644
--- a/src/gui/keymap.cpp
+++ b/src/gui/keymap.cpp
@@ -887,7 +887,7 @@ static QHash<QString, Key> getMap(KeyMap::Model model, KeyMap::Layout layout){
map["volup"].x += 10;
map["voldn"].x += 10;
- map["logo"] = {nullptr, "Logo", "logo", 128, 0, NS, true, false};
+ map["topbar1"] = {nullptr, "Logo", "topbar1", 128, 0, NS, true, false};
map.remove("m3");
map.remove("g11");
|
@JohnoKing That's awesome! I added the patch to the PR. |
i confirmed this works on my k70 pro The daemon had a warning tho
|
Same here, it works on mine, thanks ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the K70 RGB Pro (1bb3)
All the LEDs are working except the logo light. If there are ideas about how to get the logo light working I'm happy to make the change and testFixed with @JohnoKing's patch.closes #865
closes #915
closes #928
closes #998