Method editor.addCommand should accept command instances

[mlewand]

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

Currently editor.addCommand method will always convert given command to a base CKEDITOR.command class instance.

1. Execute following code:

var styleDefinition = {
		element: 'span',
		attribtues: {
			class: 'foo'
		}
	},
	style = new CKEDITOR.style( styleDefinition ),
	cmd = new CKEDITOR.command( editor, new CKEDITOR.styleCommand( style ) );


editor.addCommand( 'cmd', cmd );

console.log( editor.getCommand( 'cmd' ) === cmd );

Expected result

Console log should report true, it should be possible to add command instances inheriting from or being a CKEDITOR.command instance.

Actual result

Console log reports false.

[mlewand]

Originally this ticket was exampled using a CKEDITOR.styleCommand instance. However there's a catch here in the fact that CKEDITOR.styleCommand inherits from CKEDITOR.commandDefinition. So CKEDITOR.styleCommand is not a command but a definition (contrary to what the name suggests).

In that case I'll modify this issue to be a generic, and so that editor.addCommand accepts command instances.