fix variable name typo in dialogui plugin #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh... I wanted to say – how could tests not catch this?! But I realised that Anyway, thanks for the patch. I'd normally ask for tests for this patch, but taking into account its simplicity and lack of other tests, that would be senseless. |
Reinmar
added a commit
that referenced
this pull request
Jun 15, 2015
Fixed variable name typo in dialogui plugin which caused CKEDITOR.ui.dialog.radio validation to not work.
|
Actually I have no idea how to trigger this. It was an "typoed grep" that found this in the first place. Anyway, many words for a such a small patch :) |
|
I had to justify why I haven't included/requested tests ;). And well... such bugs are embarrassing :D. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as noticed by my colleague @BFriedrichs