Stylescombo not in the correct order in Chrome #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for the patch. I targeted #9029 for 4.0.2 so we'll review it in few days. |
|
Thanks, good news! And here is a background that explain why the OP had problem with more than 10 styles https://github.com/v8/v8/blob/master/src/array.js#L801: Chrome V8 does InsertionSort() instead of Quick Sort when the array has 10 or less elements. |
|
As #9029 is closed and merged to master this pull request should be closed too. |
mdenburger
pushed a commit
to onehippo/ckeditor
that referenced
this pull request
Dec 3, 2013
Update README.md
mdenburger
pushed a commit
to onehippo/ckeditor
that referenced
this pull request
Dec 3, 2013
Add norwegian translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not tested as I don't know how to build. However this should fix bug http://dev.ckeditor.com/ticket/9029.