Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylescombo not in the correct order in Chrome #20

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@jcisio
Copy link

commented Jan 3, 2013

I have not tested as I don't know how to build. However this should fix bug http://dev.ckeditor.com/ticket/9029.

@Reinmar

This comment has been minimized.

Copy link
Member

commented Jan 3, 2013

Hi. Thanks for the patch. I targeted #9029 for 4.0.2 so we'll review it in few days.

@jcisio

This comment has been minimized.

Copy link
Author

commented Jan 3, 2013

Thanks, good news! And here is a background that explain why the OP had problem with more than 10 styles https://github.com/v8/v8/blob/master/src/array.js#L801: Chrome V8 does InsertionSort() instead of Quick Sort when the array has 10 or less elements.

@Reinmar

This comment has been minimized.

Copy link
Member

commented Feb 17, 2013

As #9029 is closed and merged to master this pull request should be closed too.

@Reinmar Reinmar closed this Feb 17, 2013

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.