Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8724 Add quick table feature #92

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@danyaPostfactum
Copy link
Contributor

danyaPostfactum commented Apr 7, 2014

http://dev.ckeditor.com/ticket/8724

qucktable

Issues:

  • Currently the whole table (that in dropdown panel) is focusable. Should each table cell be focusable?
  • Currently "more..." button uses cke_colormore class. Selected cells have inline background style.
  • Localization
  • Default values: maxrows/maxcolumns, table attributes and style. Currently table has border=1 and width:100%
@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Apr 8, 2014

Thanks! The feature and code looks totally awesome. As soon as we'll be done with 4.4 we'll review it.

@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Jun 27, 2014

Hey. Sorry for late reply, but we hit the same problem as in #100 (comment) - we don't have contributor agreement ready yet.

I actually started a review some time ago and the first thing which I noticed was that this feature should be extracted to a separate plugin extending the basic table plugin. Better separation serves for better configurability and alternatively we would have to add a configuration option.

We'll get back to this pull request as soon as we have contributor agreement.

@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Aug 18, 2014

The quick table feature was extracted to Quicktable plugin by ufdada. Huge thanks to both of you! :) I think that I can close the PR now.

@Reinmar Reinmar closed this Aug 18, 2014

mlewand pushed a commit to mlewand/ckeditor-dev that referenced this pull request Mar 13, 2016

abogaart added a commit to onehippo/ckeditor that referenced this pull request Apr 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.