Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration PFW Image with Safari #1134

Closed
msamsel opened this issue Nov 8, 2017 · 8 comments · Fixed by #4339
Closed

Integration PFW Image with Safari #1134

msamsel opened this issue Nov 8, 2017 · 8 comments · Fixed by #4339
Assignees
Labels
browser:safari The issue can only be reproduced in the Safari browser. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@msamsel
Copy link
Contributor

msamsel commented Nov 8, 2017

Task for reminding that PFW Image should be tested with Safari, when upstream issue will be merged.

Are you reporting a feature request or a bug?

Task/bug
https://bugs.webkit.org/show_bug.cgi?id=124391

Provide detailed reproduction steps (if any)

Check how PFW Image behave on Safari. Right now Safari doesn't allow on reading RTF clipboard in browser. Link above shows that soon this will change and proper implementation will be made on Safari side (current safari preview version still doesn't support RTF).
We should test how well PFW Image will integrate with Safari, and correct possible bugs if such appear.

Other details

  • Browser: Safari
  • OS: MacOS
  • CKEditor version: 4.8.0+
  • Installed CKEditor plugins: Paste from word
@msamsel msamsel added browser:safari The issue can only be reproduced in the Safari browser. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Nov 8, 2017
@mlewand mlewand added this to the 4.8.1 milestone Nov 27, 2017
@mlewand
Copy link
Contributor

mlewand commented Nov 27, 2017

WebKit team claims to have that fixed - https://developer.apple.com/safari/technology-preview/release-notes/ (release 42)

tarted pasting images in RTF and RTFD contents using blob URLs

However I just checked it with release 44 and it still doesn't work.

@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 27, 2017
@msamsel
Copy link
Contributor Author

msamsel commented Jan 5, 2018

I've test it also on Safari Preview 46 and still doesn't work as it should. I've make a comment in their task and I hope that someone will be able to explain what happen.

@msamsel msamsel self-assigned this Jan 5, 2018
@msamsel
Copy link
Contributor Author

msamsel commented Jan 15, 2018

Since STP 47, blob url appear in text/html content for new Word.

@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
@mlewand
Copy link
Contributor

mlewand commented Jan 30, 2018

Moving issue to backlog, it's no longer critical for 4.9.0 release.

@mlewand mlewand modified the milestones: 4.9.0, Backlog Jan 30, 2018
@jswiderski
Copy link
Contributor

jswiderski commented Apr 3, 2018

This is still an issue in latest CKEditor 4.9.1 so I'm not really sure how Webkit team could mark this issue as "Fixed" instead of "Won't Fix" or "Vendor Fix" if this indeed is MS Word problem.

Looking at the blog post from Webkit, it looks like they have found other way (blob URLs) to paste images from MS Word. Please have a look at "Pasting HTML Content with Images" section in https://webkit.org/blog/8170/clipboard-api-improvements/.

Perhaps this is something we could look into.

@msamsel
Copy link
Contributor Author

msamsel commented Apr 9, 2018

@jswiderski Safari solved the issue in a different way than implementation in Chrome and Firefox. That's why it's required to make additional integration dedicated to Safari browser to support pasting images from Word.

@Comandeer Comandeer assigned Comandeer and unassigned msamsel May 29, 2018
@jswiderski
Copy link
Contributor

Thx @msamsel for explaining but what you have written is basically the same what I have written in second paragraph.

@f1ames f1ames removed the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 12, 2019
@Comandeer Comandeer self-assigned this Oct 19, 2020
@Comandeer Comandeer removed this from the Backlog milestone Oct 19, 2020
@f1ames f1ames removed the size:L label Oct 26, 2020
@CKEditorBot
Copy link
Collaborator

Closed in #4339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:safari The issue can only be reproduced in the Safari browser. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
7 participants