Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon toolbar does not match a single selected image using cssSelector #1274

Closed
mlewand opened this issue Nov 29, 2017 · 1 comment
Closed

Balloon toolbar does not match a single selected image using cssSelector #1274

mlewand opened this issue Nov 29, 2017 · 1 comment
Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.9.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 29, 2017

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open /plugins/balloontoolbar/context/manual/complex manual test.
  2. Insert an image.
  3. Select an image.

Expected result

Toolbar is shown, as there is a context for a[href], img.

Actual result

No toolbar is shown.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.8.0
@mlewand mlewand added plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. target:minor Any docs related issue that can be merged into a master or major branch. labels Nov 29, 2017
@mlewand mlewand added this to the 4.8.1 milestone Nov 29, 2017
@mlewand
Copy link
Contributor Author

mlewand commented Nov 29, 2017 •
edited
Loading

I have pushed a proposal solution for this issue to t/1274 branch. However it's based on major rather than master since 4.8.0 is not yet merged to the master branch, so it should be rebased.

@Comandeer Comandeer mentioned this issue Dec 1, 2017
Closed
@mlewand mlewand self-assigned this Dec 15, 2017
@mlewand mlewand mentioned this issue Dec 27, 2017
Merged
2 tasks
@mlewand mlewand removed their assignment Dec 27, 2017
@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
1 participant
@mlewand