Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate "Paste" language string in Clipboard plugin #1713

Closed
AnnaTomanek opened this issue Feb 23, 2018 · 1 comment · Fixed by #2252
Closed

Duplicate "Paste" language string in Clipboard plugin #1713

AnnaTomanek opened this issue Feb 23, 2018 · 1 comment · Fixed by #2252
Assignees
@jacekbogdanski
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.0

Comments

@AnnaTomanek
Copy link
Contributor

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

When adding the Paste dialog back, we created new language strings and duplicated "Paste".

paste: 'Paste',
...
title: 'Paste'

Expected result

The existing language string should be reused, with meta language string expanded.

Actual result

Translation progress is down for all languages and all localizations have an untranslated entry where, in fact, there is often the correct translation already available in the same file.
@AnnaTomanek AnnaTomanek added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Feb 23, 2018
@mlewand
Copy link
Contributor

mlewand commented Feb 23, 2018

This dialog has been reverted, so we have it as it were in version 4.6.x (including all the original translations). We don't want to add extra noise now to the major branch, so putting this issue to the backlog.

@mlewand mlewand added this to the Backlog milestone Feb 23, 2018
@mlewand mlewand added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:clipboard The plugin which probably causes the issue. target:minor Any docs related issue that can be merged into a master or major branch. labels Feb 23, 2018
@jacekbogdanski jacekbogdanski self-assigned this Jul 24, 2018
@jacekbogdanski jacekbogdanski mentioned this issue Jul 24, 2018
Merged
@mlewand mlewand modified the milestones: Backlog, 4.11.0 Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging a pull request may close this issue.

Removed duplicated lang entry for clipboard ckeditor/ckeditor4
3 participants
@AnnaTomanek @mlewand @jacekbogdanski