Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom color name not used as a label in Color Button plugin #2271

Closed
mlewand opened this issue Jul 30, 2018 · 1 comment
Closed

Custom color name not used as a label in Color Button plugin #2271

mlewand opened this issue Jul 30, 2018 · 1 comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.10.1

Comments

@mlewand
Copy link
Contributor

mlewand commented Jul 30, 2018 •
edited
Loading

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open https://codepen.io/mlewand/pen/QBadva
  2. Click "Background Color" button.
  3. Move the cursor over the orange color button.
  4. Wait until the title/label appears.

Expected result

The tooltip should be "FontColor1".

Actual result

The tooltip is "FF9900".

Other details

I can reproduce it even with 4.3.2 so it's probably not a regression.

Originally reported in egeloen/IvoryCKEditorBundle#204.

  • Browser: Any
  • OS: Any
@mlewand mlewand added type:bug A bug. status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. plugin:colorbutton The plugin which probably causes the issue. labels Jul 30, 2018
@mlewand mlewand mentioned this issue Jul 30, 2018
Merged
@mlewand mlewand changed the title Custom color label not used as label Custom color name not used as a label in Color Button plugin Jul 30, 2018
@mlewand mlewand mentioned this issue Jul 30, 2018
Merged
2 tasks
@mlewand mlewand added this to the 4.10.1 milestone Jul 30, 2018
@mlewand
Copy link
Contributor Author

mlewand commented Jul 30, 2018

I'm happy to inform that the issue landed in the master branch and is scheduled to be released in version 4.10.1.

You can have an early peek at it here: https://codepen.io/mlewand/pen/mjpqRP.

@mlewand mlewand mentioned this issue Jul 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.10.1
Development

No branches or pull requests
1 participant
@mlewand