Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize handler is not created for images in read-only mode #2874

Closed
Dumluregn opened this issue Feb 28, 2019 · 1 comment
Closed

Resize handler is not created for images in read-only mode #2874

Dumluregn opened this issue Feb 28, 2019 · 1 comment
Assignees
@Dumluregn
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:image2 The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.4

Comments

@Dumluregn
Copy link
Contributor

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Create read-only instance of editor containing image
  2. Open webpage
  3. Paste and execute following code in console:
CKEDITOR.instances.editor1.setReadOnly( false );
  1. Try to resize image in the first editor.

Expected result

  • Resize handler is visible
  • Image can be resized

Actual result

  • Resize handler is not visible
  • Image can not be resized

Other details

  • Installed CKEditor plugins: image2

#719 made resize handler disabled if editor is created in read-only mode. However it is not initialised at all, so after manually leaving read-only mode resize handler still does not show up.
Note that this is an issue only for images loaded with editor. If you add a new image afterwards (i.e. after leaving read-only mode), the problem does not exist.
@Dumluregn Dumluregn added type:bug A bug. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:image2 The plugin which probably causes the issue. labels Feb 28, 2019
@f1ames f1ames added the status:confirmed An issue confirmed by the development team. label Mar 1, 2019
@Dumluregn Dumluregn self-assigned this Mar 1, 2019
@jacekbogdanski jacekbogdanski mentioned this issue Mar 3, 2019
Merged
2 tasks
@f1ames f1ames added the target:minor Any docs related issue that can be merged into a master or major branch. label Mar 19, 2019
@f1ames f1ames added this to the 4.11.4 milestone Mar 22, 2019
@f1ames
Copy link
Contributor

f1ames commented Mar 26, 2019

Closed in 4b08ca6.

@f1ames f1ames closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dumluregn Dumluregn

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:image2 The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.4
Development

No branches or pull requests
2 participants
@f1ames @Dumluregn