Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept floating point values for table cell height and width #3164

Closed
Dumluregn opened this issue Jun 14, 2019 · 0 comments · Fixed by #3075
Closed

Accept floating point values for table cell height and width #3164

Dumluregn opened this issue Jun 14, 2019 · 0 comments · Fixed by #3075
Labels
plugin:tabletools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.12.0

Comments

@Dumluregn
Copy link
Contributor

Dumluregn commented Jun 14, 2019 •
edited
Loading

Type of report

Feature request

Provide description of the new feature

For now floating point values are parsed to integer. We could change it just by replacing parseInt() with parseFloat() in a few lines of code. Then users will be able to use popular height/width values like 33.3%.
@Dumluregn Dumluregn added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:tabletools The plugin which probably causes the issue. labels Jun 14, 2019
@Dumluregn Dumluregn mentioned this issue Jun 14, 2019
Merged
2 tasks
@f1ames f1ames added this to the 4.12.0 milestone Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:tabletools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Add unit type selection for table cell height ckeditor/ckeditor4
2 participants
@f1ames @Dumluregn