Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit Ajax helpers for new response types #4394

Closed
jacekbogdanski opened this issue Nov 23, 2020 · 2 comments · Fixed by #4440
Closed

Explicit Ajax helpers for new response types #4394

jacekbogdanski opened this issue Nov 23, 2020 · 2 comments · Fixed by #4440
Assignees
@sculpt0r
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:ajax The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.16.0

Comments

@jacekbogdanski
Copy link
Member

Type of report

Feature request

Provide description of the new feature

Recently we've introduced an additional arraybuffer response type to the ajax load method. Since we already have semantic loadXml method and now load accepts additional type argument, we should unify API by adding additional:

  • loadText
  • loadBinary

helpers. See #4339 (review) for more details.
@jacekbogdanski jacekbogdanski added type:feature A feature request. status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. size:XS plugin:ajax The plugin which probably causes the issue. labels Nov 23, 2020
@jacekbogdanski
Copy link
Member Author

Let's also add a changelog entry about the new responseType argument accepted by ajax.load method as it should be also useful for the community.

@sculpt0r sculpt0r self-assigned this Dec 15, 2020
@sculpt0r sculpt0r mentioned this issue Dec 15, 2020
Merged
3 tasks
@CKEditorBot
Copy link
Collaborator

Closed in #4440

@CKEditorBot CKEditorBot added this to the 4.16.0 milestone Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculpt0r sculpt0r

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:ajax The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.16.0
Development

Successfully merging a pull request may close this issue.

Explicit Ajax helpers for new response types ckeditor/ckeditor4
3 participants
@sculpt0r @jacekbogdanski @CKEditorBot