Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the throttling timeout configurable #2541

Closed
Reinmar opened this issue Jul 13, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-autosave#16
Closed

Make the throttling timeout configurable #2541

Reinmar opened this issue Jul 13, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-autosave#16
Labels
package:autosave type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 20

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 13, 2018

I'm afraid that the current 500ms is too fast for most integrations.
@Reinmar
Copy link
Member Author

Reinmar commented Jul 13, 2018

I changed it to 1000ms because it created too much noise even for the sample.

Still, it should be configurable. But we should perhaps think on https://github.com/ckeditor/ckeditor5-autosave/issues/12 first.

@pjasiun
Copy link

pjasiun commented Jul 26, 2018

After https://github.com/ckeditor/ckeditor5-autosave/issues/12#issuecomment-408116612 default timeout should work in most cases and is should not need to be configurable.

pjasiun referenced this issue in ckeditor/ckeditor5-autosave Aug 16, 2018
Merge pull request #16 from ckeditor/t/12
820e060 
Other: Improved call frequency. Closes #9. Closes #10. Closes #12. Closes ckeditor/ckeditor5#1158.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-autosave Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:autosave labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:autosave type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 20
Development

Successfully merging a pull request may close this issue.

Improve call frequency ckeditor/ckeditor5-autosave
3 participants
@Reinmar @pjasiun @mlewand