Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minify CSS #2139

Closed
Reinmar opened this issue Apr 6, 2017 · 2 comments
Closed

Minify CSS #2139

Reinmar opened this issue Apr 6, 2017 · 2 comments
Assignees
@Reinmar
Labels
package:build-classic type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 10

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 6, 2017

I noticed we don't minify CSS here :D
@Reinmar
Copy link
Member Author

Reinmar commented Apr 6, 2017

This is the way to do that: https://github.com/ckeditor/ckeditor5-labs/blob/af3bc69c78a65f6c6334a73c7e076852d4a61300/integrations/webpack/webpack.config.js#L51

@Reinmar
Copy link
Member Author

Reinmar commented May 3, 2017

Interestingly, even though the build to which I compared the size was done on a month old codebase (with less features), after enabling CSS minification the overal size decreased so there was quite a lot to gain.

Old buid:

-rw-r--r--   1 p  staff   743783 20 Apr 13:34 ckeditor.compat.js
-rw-r--r--   1 p  staff   418135 20 Apr 13:34 ckeditor.js

New build:

-rw-r--r--   1 p  staff   740860  3 May 18:48 ckeditor.compat.js
-rw-r--r--   1 p  staff   412210  3 May 18:47 ckeditor.js

@Reinmar Reinmar self-assigned this May 3, 2017
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-build-classic Oct 8, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:build-classic labels Oct 8, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:build-classic type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 10
Development

No branches or pull requests
2 participants
@Reinmar @mlewand