-
Notifications
You must be signed in to change notification settings - Fork 7
Initial implementation of the code block feature #1
Conversation
…code block is not split.
…getSelectedContent().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one huge of a PR :)
I was fixing smaller things I found just to speed up things and I the feedback is mostly to @oleq's additions.
From the bigger things to change IMO:
- split indent command (smaller == easier to digest === simpler)
- maybe the config should be a bit different
From the other things (follow ups?):
the dropdown menu has two scrolls:
the code block inside table is hidden under the code block lang label (make it transluscent? but this is definetely a follow up
Co-Authored-By: Maciej <jodator@jodator.net>
Co-Authored-By: Maciej <jodator@jodator.net>
Co-Authored-By: Maciej <jodator@jodator.net>
Co-Authored-By: Maciej <jodator@jodator.net>
…-box compatibility with 3rd-party highlighters.
Fixed.
I went from |
…lasses are now generated from #language or customized using #class.
🚀 😍 LGTM merging after CI :D |
Suggested merge commit message (convention)
Feature: Initial implementation of the code block feature. Closes ckeditor/ckeditor5#436. Closes ckeditor/ckeditor5#5664. Closes ckeditor/ckeditor5#5666.
Requires ckeditor/ckeditor5-theme-lark#251.
To be followed by ckeditor/ckeditor5-autoformat#78.
You can check out the documentation under development for more information (feature guide) https://github.com/ckeditor/ckeditor5-code-block/compare/i/5668?expand=1.
TODO: