Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Initial implementation of the code block feature #1

Merged
merged 82 commits into from
Nov 20, 2019
Merged

Conversation

oskarwrobel
Copy link
Contributor

@oskarwrobel oskarwrobel commented Oct 25, 2019

@dkonopka
Copy link

I've polished icon a bit:

Before:

Screenshot 2019-10-29 at 09 52 25

After:

Screenshot 2019-10-29 at 09 49 51

Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one huge of a PR :)

I was fixing smaller things I found just to speed up things and I the feedback is mostly to @oleq's additions.

From the bigger things to change IMO:

  • split indent command (smaller == easier to digest === simpler)
  • maybe the config should be a bit different

From the other things (follow ups?):

the dropdown menu has two scrolls:

Selection_061

the code block inside table is hidden under the code block lang label (make it transluscent? but this is definetely a follow up
Selection_060

src/codeblock.js Outdated Show resolved Hide resolved
tests/codeblock.js Outdated Show resolved Hide resolved
src/codeblockcommand.js Outdated Show resolved Hide resolved
src/codeblockediting.js Outdated Show resolved Hide resolved
src/codeblockediting.js Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/codeblockui.js Outdated Show resolved Hide resolved
src/codeblockui.js Outdated Show resolved Hide resolved
src/indentcodeblockcommand.js Outdated Show resolved Hide resolved
tests/manual/codeblock.html Show resolved Hide resolved
@oleq
Copy link
Member

oleq commented Nov 19, 2019

the dropdown menu has two scrolls:

Fixed.

the code block inside table is hidden under the code block lang label (make it transluscent? but this is definetely a follow up

I went from min-width: 60px to 200px which helps (sort of). Such narrow code blocks do not make sense in the first place so I wouldn't worry about it anyway.

@jodator
Copy link
Contributor

jodator commented Nov 20, 2019

🚀 😍 LGTM merging after CI :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants