Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Initial implementation of the code block feature #1

Merged
merged 82 commits into from
Nov 20, 2019
Merged

Initial implementation of the code block feature #1

merged 82 commits into from
Nov 20, 2019

Commits on Oct 22, 2019

  1. Initial code block implementation.

    @oskarwrobel
    oskarwrobel committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    09edfa1 View commit details
    Browse the repository at this point in the history

  2. Introduced very basic manual test.

    @oskarwrobel
    oskarwrobel committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    7596429 View commit details
    Browse the repository at this point in the history

  3. Typo.

    @oskarwrobel
    oskarwrobel committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    f698c3c View commit details
    Browse the repository at this point in the history

  4. Added automated tests for CodeBlock and CodeBlockUI plugins.

    @oskarwrobel
    oskarwrobel committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    646b0f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Added pluginName property and plugin dependency.

    @oskarwrobel
    oskarwrobel committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    e303f46 View commit details
    Browse the repository at this point in the history

  2. Code improvements.

    @oskarwrobel
    oskarwrobel committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    430e499 View commit details
    Browse the repository at this point in the history

  3. Added tests for CodeBlockCommand plugin.

    @oskarwrobel
    oskarwrobel committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    3ac250e View commit details
    Browse the repository at this point in the history

  4. Added test for CodeBlockEditing plugin.

    @oskarwrobel
    oskarwrobel committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    07edaf3 View commit details
    Browse the repository at this point in the history

  5. Bumped dependencies.

    Damian Konopka committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    1c803e8 View commit details
    Browse the repository at this point in the history

  6. Added temporary icon.

    Damian Konopka committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    ed47dda View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Improved data conversion to properly handle HTML inside a pre tag.

    @oskarwrobel
    oskarwrobel committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    24ee9b5 View commit details
    Browse the repository at this point in the history

  2. Minor docs improvement.

    @oskarwrobel
    oskarwrobel committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    ead8aa9 View commit details
    Browse the repository at this point in the history

  3. Style improvements.

    @oskarwrobel
    oskarwrobel committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    8c491a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Changed code block view structure from pre to pre > code.

    @oskarwrobel
    oskarwrobel committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    7c366a4 View commit details
    Browse the repository at this point in the history

  2. Changed new line character to <br> for the editing pipeline.

    @oskarwrobel
    oskarwrobel committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    c7e1275 View commit details
    Browse the repository at this point in the history

  3. Increased CC to 100%.

    @oskarwrobel
    oskarwrobel committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    0c3fe6d View commit details
    Browse the repository at this point in the history

  4. Updated dependencies.

    @oskarwrobel
    oskarwrobel committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    aad8a51 View commit details
    Browse the repository at this point in the history

  5. Improved .ck-content styles.

    dkonopka committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    b346b64 View commit details
    Browse the repository at this point in the history

  6. Updated SVG icon.

    dkonopka committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    956c7b1 View commit details
    Browse the repository at this point in the history

  7. Improved manual test.

    @oskarwrobel
    oskarwrobel committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    fe3f241 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Polish the icon once again.

    Damian Konopka committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    f10781a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into t/ckeditor5/436

    @pomek
    pomek committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    431bed8 View commit details
    Browse the repository at this point in the history

  3. Restored the proper content of README.md.

    @pomek
    pomek committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    e6930bb View commit details
    Browse the repository at this point in the history

  4. Removed package-lock.

    @pomek
    pomek committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    691def7 View commit details
    Browse the repository at this point in the history

  5. Tests: Fixed a wrong import in the manual test (should be relative).

    @oleq
    oleq committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    7e57bcc View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. The feature should handle clipboard input and make sure the existing … 

    …code block is not split.
    @oleq
    oleq committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    389b92a View commit details
    Browse the repository at this point in the history

  2. Tests: Extended the manual test.

    @oleq
    oleq committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    cf41cc2 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Tests: Added RTL manual test.

    @oleq
    oleq committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    50394c6 View commit details
    Browse the repository at this point in the history

  2. Allowed setting code block language via the CodeBlockCommand.

    @oleq
    oleq committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    e679fc5 View commit details
    Browse the repository at this point in the history

  3. Tests: Extended the manual test with more data.

    @oleq
    oleq committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    dc49a49 View commit details
    Browse the repository at this point in the history

  4. Fixed the code block appeareance in RTL content. Fixed the long code … 

    …overflow issue.
    @oleq
    oleq committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    9057a70 View commit details
    Browse the repository at this point in the history

  5. Moved layout block styles from ckeditor5-theme-lark.

    @oleq
    oleq committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    dc054df View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. Default feature config and the "language" attribute in the model foll… 

    …owed by the "class" attribute in the view.
    @oleq
    oleq committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    c96fdd8 View commit details
    Browse the repository at this point in the history

  2. Docs: Documented the feature config.

    @oleq
    oleq committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    bcd71dc View commit details
    Browse the repository at this point in the history

  3. Tests: Added CodeBlockCommand tests to check if the "language" option… 

    … is supported when executing.
    @oleq
    oleq committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    c8fa809 View commit details
    Browse the repository at this point in the history

  4. Code refactoring.

    @oleq
    oleq committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    cb713aa View commit details
    Browse the repository at this point in the history

  5. Make sure the "Plain text" label from the config is correctly transla… 

    …ted.
    @oleq
    oleq committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    627453a View commit details
    Browse the repository at this point in the history

  6. Implemented the "codeBlock" dropdown with a split button and a list o… 

    …f available languages.
    @oleq
    oleq committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    e5bcb95 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Make sure the code block splits parents when upcasting if not allowed… 

    …. Checked upcasting multiple code blocks in a row (WIP).
    @oleq
    oleq committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    1e1078d View commit details
    Browse the repository at this point in the history

  2. Tests: Added a test to check what happens if an unsplittable parent d… 

    …oes not allow codeBlock during upcasting.
    @oleq
    oleq committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    32ebac9 View commit details
    Browse the repository at this point in the history

  3. Tests: "Fixed" CodeBlockEditing some failing assertions by adding a c… 

    …omment explaining that the issue is not in the package.
    @oleq
    oleq committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    88c4a7f View commit details
    Browse the repository at this point in the history

  4. Double enter at the end of the code block should exit it.

    @oleq
    oleq committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    1a16fec View commit details
    Browse the repository at this point in the history

  5. Improvements to the code block CSS.

    @oleq
    oleq committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    60ac249 View commit details
    Browse the repository at this point in the history

  6. Double shift enter should not leave the code block when executed at t… 

    …he end of it.
    @oleq
    oleq committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    55b3c91 View commit details
    Browse the repository at this point in the history

  7. Used tab-size for the pre for better look.

    @oleq
    oleq committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    0883d18 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2019

  1. Indentation retention when pressing enter.

    @oleq
    oleq committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    bf53c02 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. Ensured the code block is properlu copied to the clipboard (getSelect… 

    …edContent() integration).
    @oleq
    oleq committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    9c2b363 View commit details
    Browse the repository at this point in the history

  2. Enabled the Autoformat plugin in the manual test.

    @oleq
    oleq committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    7f9ccfe View commit details
    Browse the repository at this point in the history

  3. Used model writer to customize the getSelectedContent() method behavior.

    @oleq
    oleq committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    a539459 View commit details
    Browse the repository at this point in the history

  4. Do not customize getSelectedContent() when the selection is empty.

    @oleq
    oleq committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    604f7ff View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Tests: Code refactoring.

    @oleq
    oleq committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    7bd9b0a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Created the IndentCodeBlockCommand.

    @oleq
    oleq committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    b3e69eb View commit details
    Browse the repository at this point in the history

  2. Enabled code block indent and outdent commands in the editing. Define… 

    …d config.codeBlock.indentSequence.
    @oleq
    oleq committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    60c3282 View commit details
    Browse the repository at this point in the history

  3. Docs and code refactoring.

    @oleq
    oleq committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    42177ec View commit details
    Browse the repository at this point in the history

  4. Removed the dotAll flag from the extractDataFromCodeElement() regex d… 

    …ue to errors in Firefox (not supported).
    @oleq
    oleq committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    31e21c8 View commit details
    Browse the repository at this point in the history

  5. Added missing dependencies to package.json.

    @oleq
    oleq committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    a6b1338 View commit details
    Browse the repository at this point in the history

  6. Allowed leaving the code block by pressing enter in an empty line at … 

    …the beginning of the block.
    @oleq
    oleq committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    dc7daf8 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Improved the feature icon.

    @oleq
    oleq committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    2812a64 View commit details
    Browse the repository at this point in the history

  2. Tests: Added missing scenarios to feature's manual test.

    @oleq
    oleq committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    0c9065c View commit details
    Browse the repository at this point in the history

  3. Updated the feature button's label. Added the contexts.json file.

    @oleq
    oleq committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    e8a8a09 View commit details
    Browse the repository at this point in the history

  4. Tests: Fixed a failing test after change of the button's label.

    @oleq
    oleq committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    aa04ce6 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Make sure the "code" attribute is allowed when marking the output of … 

    …getSelectedContent().
    @oleq
    oleq committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    cd6ff0b View commit details
    Browse the repository at this point in the history

  2. Enhance description of CodeBlockCommand#value tests.

    @jodator
    jodator committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    f5467b2 View commit details
    Browse the repository at this point in the history

  3. Further enhance description of CodeBlockCommand tests.

    @jodator
    jodator committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    f71146c View commit details
    Browse the repository at this point in the history

  4. Update description of indentcodeblockcommand tests.

    @jodator
    jodator committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    d89c775 View commit details
    Browse the repository at this point in the history

  5. Simplify canBeCodeBlock() schema check return value.

    @jodator
    jodator committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    e6f9b30 View commit details
    Browse the repository at this point in the history

  6. Remove superfluous schema child check for codeBlock in code block.

    @jodator
    jodator committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    ce8e35b View commit details
    Browse the repository at this point in the history

  7. Typo fix.

    @jodator
    jodator committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    011e4f5 View commit details
    Browse the repository at this point in the history

  8. Use explicit schema definition for codeBlock.

    @jodator
    jodator committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    9096a36 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Update tests/codeblock.js 

    Co-Authored-By: Maciej <jodator@jodator.net>
    @oleq @jodator
    oleq and jodator committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    9e04100 View commit details
    Browse the repository at this point in the history

  2. Update src/codeblockcommand.js 

    Co-Authored-By: Maciej <jodator@jodator.net>
    @oleq @jodator
    oleq and jodator committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    5c2731c View commit details
    Browse the repository at this point in the history

  3. Update src/utils.js 

    Co-Authored-By: Maciej <jodator@jodator.net>
    @oleq @jodator
    oleq and jodator committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    416d93e View commit details
    Browse the repository at this point in the history

  4. Update src/codeblockediting.js 

    Co-Authored-By: Maciej <jodator@jodator.net>
    @oleq @jodator
    oleq and jodator committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    fef2daa View commit details
    Browse the repository at this point in the history

  5. Changed the language classes in the default config for the out-of-the… 

    …-box compatibility with 3rd-party highlighters.
    @oleq
    oleq committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    433ee42 View commit details
    Browse the repository at this point in the history

  6. The code block should not be squashed in a table cell.

    @oleq
    oleq committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    2a04f58 View commit details
    Browse the repository at this point in the history

  7. Code refactoring.

    @oleq
    oleq committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    a86b1a4 View commit details
    Browse the repository at this point in the history

  8. Code refactoring.

    @oleq
    oleq committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    6b525b9 View commit details
    Browse the repository at this point in the history

  9. Created separated IndentCodeBlockCommand and OutdentCodeBlockCommand … 

    …classes.
    @oleq
    oleq committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    60e2c9b View commit details
    Browse the repository at this point in the history

  10. Let's give the code block even more air in tight spaces.

    @oleq
    oleq committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    c6e69ef View commit details
    Browse the repository at this point in the history

  11. Minor fix.

    @oleq
    oleq committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    c2797b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Changed the configuration format (CodeBlockLanguageDefinition). CSS c… 

    …lasses are now generated from #language or customized using #class.
    @oleq
    oleq committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    da2349f View commit details
    Browse the repository at this point in the history

  2. Remove the link to the API page that could break CI.

    @jodator
    jodator committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    4f3b521 View commit details
    Browse the repository at this point in the history