Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should a keystroke be always disabled when a related command is disabled? #5768

Closed
oleq opened this issue Nov 21, 2019 · 2 comments
Closed
Labels
package:code-block package:list resolution:expired This issue was closed due to lack of feedback. status:stale type:question This issue asks a question (how to...).

Comments

@oleq
Copy link
Member

oleq commented Nov 21, 2019

A follow-up of ckeditor/ckeditor5-code-block#1 (comment).

Problem

Use case with lists

  1. Create a list with 2 items.
  2. Move the selection to the second one.
  3. Tab to indent.
  4. Tab to indent again.

There's no way to indent more so the indent command is disabled so is the Tab keystroke. When the user hits Tab, it falls back to default behavior that cycles focus on the entire webpage. This could be very confusing because you edit some lists and then suddenly you're somewhere else.

Use case with code blocks

  1. Create a code block.
  2. Indent some line.
  3. Put selection in that line.
  4. Shift+Tab to outdent.
  5. Shift+Tab to outdent again (even if there's no indentation left).

Again, when the user hits Tab, it falls back to default behavior that cycles focus on the entire webpage. And again, this could be very confusing because you edit some code and then suddenly you're somewhere else.

Comment

I think we should not bind keystrokes blindly to the commands they execute. It's a confusing UX that the keystroke changes it's behavior despite staying in the same context (list, code block).

WDYT?

@dkonopka @Reinmar @mlewand

@oleq oleq added type:question This issue asks a question (how to...). package:list package:code-block labels Nov 21, 2019
@Reinmar Reinmar added this to the backlog milestone Dec 2, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 8, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:code-block package:list resolution:expired This issue was closed due to lack of feedback. status:stale type:question This issue asks a question (how to...).
Projects
None yet
Development

No branches or pull requests

4 participants