This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Introduced relations in OT #1478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR reduces the number of skipped tests to 4, of which only 2 are in transformations (the other 2 are related to a different part of the changed code - engine debug tools). |
|
After some changes, it requires #1486 |
ma2ciek
reviewed
Aug 2, 2018
| @@ -53,6 +53,12 @@ describe( 'transform', () => { | |||
| } | |||
| } | |||
|
|
|||
| const contextIsStrong = { | |||
There was a problem hiding this comment.
IMO the name suggests a boolean option, not an object.
pjasiun
reviewed
Aug 8, 2018
| } | ||
|
|
||
| const origB = this.originalOperations.get( opB ); | ||
| const undoneB = this.document.history.getUndoneOperation( origB ); |
There was a problem hiding this comment.
I am not sure what exactly should be commented here, but I'll add extensive comments in a followup to explain every of those algorithms.
|
Moved to #1497. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Introduced relations in OT which helps solving conflicts during undo. Closes ckeditor/ckeditor5#4383.