Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Moved transformation error logging from debug tools to OT code #1480

Closed
wants to merge 4 commits into from

Conversation

scofalik
Copy link
Contributor

@scofalik scofalik commented Jul 27, 2018

Suggested merge commit message (convention)

Other: Moved transformation error logging from debug tools to OT code. Closes ckeditor/ckeditor5#4379.


Additional information

Requires #1478

@scofalik
Copy link
Contributor Author

This PR removes 2 skipped tests 🎉

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.366% when pulling 828cc08 on t/1464 into 00fbf7f on master.

@pjasiun
Copy link

pjasiun commented Aug 9, 2018

What about changes in the way how transformation functions are exported?

@pjasiun pjasiun self-requested a review August 9, 2018 09:24
@pjasiun
Copy link

pjasiun commented Aug 9, 2018

Moved to #1497.

@pjasiun pjasiun closed this Aug 9, 2018
@pjasiun pjasiun deleted the t/1464 branch August 9, 2018 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move try-catch on transformation method from engine debug tools to transformations code
3 participants