Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image's model attributes should be converted separately #5050

Closed
szymonkups opened this issue Jan 20, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-image#32
Closed

Image's model attributes should be converted separately #5050

szymonkups opened this issue Jan 20, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-image#32
Assignees
@szymonkups
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 6

Comments

@szymonkups
Copy link
Contributor

Currently src and alt attributes are converted by using buidModelConverter: imageengine L53-L55.
This is wrong because each attribute should be converted and consumed separately, there might be commands or other code that will modify only the attribute, so converter should handle add/change/removeAttribute.
@szymonkups szymonkups self-assigned this Jan 20, 2017
@szymonkups szymonkups changed the title Image's model attributes should be converted separately. Image's model attributes should be converted separately Jan 20, 2017
@Reinmar
Copy link
Member

Reinmar commented Jan 24, 2017 •
edited
Loading

Interesting mistake. I haven't even thought about this when reviewing this code. Which means that very few people may be able to notice such issues. Hence, https://github.com/ckeditor/ckeditor5-engine/issues/778.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 6 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 6
Development

Successfully merging a pull request may close this issue.

Separate converters for image attributes ckeditor/ckeditor5-image
3 participants
@Reinmar @szymonkups @mlewand