Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the window.editor from memory leaks tests. #1814

Closed
jodator opened this issue Jun 14, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-editor-inline#56, ckeditor/ckeditor5-editor-classic#92, ckeditor/ckeditor5-editor-balloon#35 or ckeditor/ckeditor5-editor-decoupled#35
Closed

Remove the window.editor from memory leaks tests. #1814

jodator opened this issue Jun 14, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-editor-inline#56, ckeditor/ckeditor5-editor-classic#92, ckeditor/ckeditor5-editor-balloon#35 or ckeditor/ckeditor5-editor-decoupled#35
Assignees
@jodator
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 25

Comments

@jodator
Copy link
Contributor

jodator commented Jun 14, 2019

The CKEditor5 causes some memory leaks and the editor should not be automatically attached to the inspector for memory leak tests.
@jodator jodator added the type:task This issue reports a chore (non-production change) and other types of "todos". label Jun 14, 2019
@jodator jodator added this to the iteration 25 milestone Jun 14, 2019
@jodator jodator self-assigned this Jun 14, 2019
This was referenced Jun 14, 2019
Merged
Merged
Merged
Merged
@oleq
Copy link
Member

oleq commented Jun 17, 2019

Somehow related: Could you please take a look at the CKEditorInspector.destroy() API implemented in ckeditor/ckeditor5-inspector#46?

@jodator jodator mentioned this issue Jun 17, 2019
Open
oleq added a commit to ckeditor/ckeditor5-editor-inline that referenced this issue Jun 18, 2019
@oleq
Merge pull request #56 from ckeditor/t/ckeditor5/1814
1bbea67 
Tests: Prevented `CKEditorInspector` auto–attachment in the memory consumption manual test. Closes ckeditor/ckeditor5#1814.
oleq added a commit to ckeditor/ckeditor5-editor-classic that referenced this issue Jun 18, 2019
@oleq
Merge pull request #92 from ckeditor/t/ckeditor5/1814
edd934c 
Tests: Prevented `CKEditorInspector` auto–attachment in the memory consumption manual test. Closes ckeditor/ckeditor5#1814.
oleq added a commit to ckeditor/ckeditor5-editor-balloon that referenced this issue Jun 18, 2019
@oleq
Merge pull request #35 from ckeditor/t/ckeditor5/1814
135c8a8 
Tests: Prevented `CKEditorInspector` auto–attachment in the memory consumption manual test. Closes ckeditor/ckeditor5#1814.
oleq added a commit to ckeditor/ckeditor5-editor-decoupled that referenced this issue Jun 18, 2019
@oleq
Merge pull request #35 from ckeditor/t/ckeditor5/1814
dfae464 
Tests: Prevented `CKEditorInspector` auto–attachment in the memory consumption manual test. Closes ckeditor/ckeditor5#1814.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 25
2 participants
@jodator @oleq