Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back 100% CC #183

Closed
pomek opened this issue Sep 18, 2020 · 1 comment · Fixed by #229
Closed

Bring back 100% CC #183

pomek opened this issue Sep 18, 2020 · 1 comment · Fixed by #229
Assignees
@pomek
Labels
squad:integrations type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 42

Comments

@pomek
Copy link
Member

pomek commented Sep 18, 2020

After merging #178, the CC will drop below 100%.
@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:devops Issue to be handled by the Devops team. labels Sep 18, 2020
@pomek pomek added this to the next milestone Sep 18, 2020
@pomek pomek mentioned this issue Sep 24, 2020
Closed
@mlewand mlewand removed the squad:devops Issue to be handled by the Devops team. label Oct 5, 2020
@pomek pomek modified the milestones: next, nice-to-have Nov 10, 2020
@pomek
Copy link
Member Author

pomek commented Mar 8, 2021

A case to cover: #197

We cannot reproduce the original error using the existing test runner. Most probably, for such a case, we need to use Jest.

@pomek pomek self-assigned this Mar 21, 2021
@pomek pomek modified the milestones: nice-to-have, iteration 42 Mar 21, 2021
@pomek pomek mentioned this issue Mar 21, 2021
Merged
ma2ciek added a commit that referenced this issue Mar 26, 2021
@ma2ciek
Merge pull request #229 from ckeditor/i/227
ca2a1ff 
Tests: Added the memory leak tests. Closes #227.

Tests: Added additional tests to cover all use-cases. Closes #183.

Tests: Added tests for dev-utils.

Tests: Grouped tests by test scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
squad:integrations type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 42
Development

Successfully merging a pull request may close this issue.

Minor improvements for package's components and tests ckeditor/ckeditor5-react
3 participants
@Reinmar @pomek @mlewand