Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchdog causes memory leaks #227

Closed
pomek opened this issue Mar 19, 2021 · 1 comment · Fixed by #229
Closed

Watchdog causes memory leaks #227

pomek opened this issue Mar 19, 2021 · 1 comment · Fixed by #229
Assignees
Milestone

Comments

@pomek
Copy link
Member

pomek commented Mar 19, 2021

☝️ Most probably the watchdog feature causes it. Whenever a new instance is created, the old reference is not destroyed (

if ( this.context instanceof ContextWatchdog ) {
this.watchdog = new EditorWatchdogAdapter( this.context );
} else {
this.watchdog = new EditorWatchdog( this.editor );
}
).

Originally posted by @pomek in ckeditor/ckeditor5#8725 (comment)

@pomek
Copy link
Member Author

pomek commented Mar 21, 2021

I've copied the memory leak test from CKEditor 5 and, fortunately, I wasn't right. The component destroys all references correctly. The test is here: 0d74194.

@pomek pomek self-assigned this Mar 21, 2021
@pomek pomek added this to the iteration 42 milestone Mar 21, 2021
ma2ciek added a commit that referenced this issue Mar 26, 2021
Tests: Added the memory leak tests. Closes #227.

Tests: Added additional tests to cover all use-cases. Closes #183.

Tests: Added tests for dev-utils.

Tests: Grouped tests by test scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant