Minor improvements for package's components and tests #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t when checking whether it should be re-mounted.
Pull Request Test Coverage Report for Build 344
💛 - Coveralls |
pomek
commented
Mar 21, 2021
ma2ciek
reviewed
Mar 25, 2021
ma2ciek
reviewed
Mar 25, 2021
src/ckeditorcontext.jsx
Outdated
| } | ||
|
|
||
| /** | ||
| * @return {JSX.Element} |
There was a problem hiding this comment.
TBH it's the React Component API. We don't need to document these methods 😅
Co-authored-by: Maciej Bukowski <ma2ciek@gmail.com>
|
LGTM. Let's work on the code improvements in another PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Tests: Added the memory leak tests. Closes #227.
Tests: Added additional tests to cover all use-cases. Closes #183.
Tests: Added tests for dev-utils.
Tests: Grouped tests by test scenarios.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.