Merge pull request #96 from ckeditor/t/ckeditor5/1385

Internal: Used `forceWeakRemove` flag in undo OT. See ckeditor/ckeditor5-engine#1678.
ckeditor · Feb 18, 2019 · fc2166a · fc2166a
2 parents 601f213 + 46a7804
commit fc2166a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/basecommand.js b/src/basecommand.js
@@ -148,7 +148,8 @@ export default class BaseCommand extends Command {
 				{
 					useRelations: true,
 					document: this.editor.model.document,
-					padWithNoOps: false
+					padWithNoOps: false,
+					forceWeakRemove: true
 				}
 			);
 

diff --git a/tests/undocommand.js b/tests/undocommand.js
@@ -266,13 +266,6 @@ describe( 'UndoCommand', () => {
 				for ( const item of model.createRangeIn( doc.graveyard ).getItems() ) {
 					expect( item.hasAttribute( 'key' ) ).to.be.false;
 				}
-
-				// Let's undo wrapping. This will remove the P element and leave us with empty root.
-				undo.execute( batch3 );
-				expect( root.maxOffset ).to.equal( 0 );
-
-				expect( editor.model.document.selection.getFirstRange().isEqual( r( 0, 0 ) ) ).to.be.true;
-				expect( editor.model.document.selection.isBackward ).to.be.false;
 			} );
 
 			it( 'should omit deltas with non-document operations', () => {