This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Used forceWeakRemove flag in undo OT #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scofalik
commented
Feb 14, 2019
| expect( root.maxOffset ).to.equal( 0 ); | ||
|
|
||
| expect( editor.model.document.selection.getFirstRange().isEqual( r( 0, 0 ) ) ).to.be.true; | ||
| expect( editor.model.document.selection.isBackward ).to.be.false; |
There was a problem hiding this comment.
I had to remove this part of the test because it started to fail. Unfortunately, this part is about more complex OT of "unwrap action". Since we removed WrapOperation and UnwrapOperation we no longer can provide fixes for such scenario.
It was working before "by accident" due to a bug in a different pair of transformations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Used
forceWeakRemoveflag in undo OT.