This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Undo and redo no longer crashes in scenarios featuring pasting content into earlier pasted content #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent into earlier pasted content.
Mgsy
approved these changes
Feb 15, 2019
|
I pasted the same content twice and undid that twice and additional list item was left:
|
|
ok, I can see that this is an unrelated issue. I'll extract it to a separate ticket. @Mgsy, unless you know about similar ticket already? |
Reinmar
added a commit
to ckeditor/ckeditor5-undo
that referenced
this pull request
Feb 18, 2019
Internal: Used `forceWeakRemove` flag in undo OT. See ckeditor/ckeditor5-engine#1678.
AFAIR, we don't have it reported. |
|
Reported: ckeditor/ckeditor5#1540 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Undo and redo no longer crashes in scenarios featuring pasting content into earlier pasted content. Closes ckeditor/ckeditor5#1385.
Additional information
Requires https://github.com/ckeditor/ckeditor5-undo/pull/96/files
I had to re-introduce
forceWeakRemoveflag. This mechanism/flag was used before when we had deltas. I figured it was no longer needed after the refactorings we had. It wasn't needed for long, however, unfortunately, those cases need it. They can't be solved in a way other than explicitly saying: "this is undo, do (not) do this or that".@Mgsy please test extensively undo after this PR as it touches multiple scenarios. Please test scenarios with merges, splits and removes. All unit tests were fine, though.