Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic selection post-fixer – part 2 #4360

Closed
Reinmar opened this issue Jun 17, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1450
Closed

Automatic selection post-fixer – part 2 #4360

Reinmar opened this issue Jun 17, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1450
Assignees
@jodator
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 19

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 17, 2018

When reviewing ckeditor/ckeditor5-engine#1431 I spotted a couple of issues which we weren't able to fix back then. Mainly – element selection of non-objects and correct way of fixing selections crossing limit boundaries.
@Reinmar
Copy link
Member Author

Reinmar commented Jun 17, 2018

I pushed tests for the issues I found to t/1436.

Reinmar referenced this issue in ckeditor/ckeditor5-engine Jul 6, 2018
@Reinmar
Merge pull request #1450 from ckeditor/t/1436
e0a5a0b 
Fix: Improved selection post-fixing mechanism for selections which cross limit element boundaries. Closes #1436.

Feature: The `schema.getLimitElement()` method now accepts also `Range` and `Position` as a parameter.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 19 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 19
Development

Successfully merging a pull request may close this issue.

T/1436: Fixing selection that cross limit node boundaries. ckeditor/ckeditor5-engine
3 participants
@Reinmar @jodator @mlewand