Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for ranges in blocks #4385

Closed
pjasiun opened this issue Jul 25, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1494
Closed

Add tests for ranges in blocks #4385

pjasiun opened this issue Jul 25, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1494
Assignees
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@pjasiun
Copy link

pjasiun commented Jul 25, 2018

Reviewing collaboration tests I met a lot of tests were the selection is next to the block ([]<paragraph>Foo</paragraph>) or around the block ([<paragraph>Foo</paragraph>]). These are valid tests for collaboration, but the selection is not realistic. The real selection will be in the block (<paragraph>[]Foo</paragraph> or <paragraph>[Foo]</paragraph>). Tests should be review and for most of the cases where the selection is next to the block, we should add an additional test for the similar case with the selection in the block (these are such tests for some cases, but there are also missing cases).

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added module:model type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants