Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in handling newline element in blockqoute #7863

Closed
jodator opened this issue Aug 18, 2020 · 1 comment · Fixed by #9931
Closed

Possible bug in handling newline element in blockqoute #7863

jodator opened this issue Aug 18, 2020 · 1 comment · Fixed by #9931
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:engine type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented Aug 18, 2020

📝 Provide detailed reproduction steps (if any)

Found here: #7859

Use HtmlDataProcessor.toView()  with (notice the \n after </pre>:

"<blockquote>\n<p>Example 1:</p>\n<pre><code>code 1</code></pre>\n<p>Example 2:</p>\n<pre><code>code 2</code></pre>\n</blockquote>\n"

This is converted to the view as (notice the </pre> </blockquote>)

"<blockquote><p>Example 1:</p><pre><code>code 1</code></pre><p>Example 2:</p><pre><code>code 2</code></pre> </blockquote>"

It is represented in the view as Text element with " " (space):

✔️ Expected result

The " " should not be inserted here.

📃 Other details

I'd suspect recent changes in handling paragraphable elements. But that's a wild guess.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Aug 18, 2020
@niegowski
Copy link
Contributor

I'd suspect recent changes in handling paragraphable elements. But that's a wild guess.

This issue is with us for many iterations, example https://ckeditor.com/docs/ckeditor5/16.0.0/features/code-blocks.html is also behaving the same way.

@mlewand mlewand added domain:dx This issue reports a developer experience problem or possible improvement. squad:dx labels Oct 26, 2020
@mlewand mlewand added this to the backlog milestone Oct 26, 2020
maxbarnas added a commit that referenced this issue Jun 21, 2021
Fix (engine): DomConverter.blockElements is missing some of the HTML block element names. Closes #9801. Closes #7863.
@Reinmar Reinmar modified the milestones: backlog, iteration 45, iteration 44 Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants