Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete DomConverter.blockElements array #9801

Closed
jacekbogdanski opened this issue Jun 1, 2021 · 0 comments 路 Fixed by #9931
Closed

Complete DomConverter.blockElements array #9801

jacekbogdanski opened this issue Jun 1, 2021 · 0 comments 路 Fixed by #9931
Assignees
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@jacekbogdanski
Copy link
Member

jacekbogdanski commented Jun 1, 2021

馃摑 Provide a description of the improvement

DomConverter.blockElements doesn't include every possible block element. We should extend it to cover additional blocks like pre, section, article etc, so basically, every HTML tag considered a block/flow element. The change is required for full HTML support to correctly handle trailing spaces.

this.blockElements = [ 'p', 'div', 'h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'li', 'dd', 'dt', 'figcaption', 'td', 'th' ];

Also, we could cover #3920


If you'd like to see this improvement implemented, add a 馃憤 reaction to this post.

@jacekbogdanski jacekbogdanski added type:improvement This issue reports a possible enhancement of an existing feature. squad:compat domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. labels Jun 1, 2021
@jacekbogdanski jacekbogdanski added this to the iteration 44 milestone Jun 1, 2021
@jacekbogdanski jacekbogdanski self-assigned this Jun 21, 2021
maxbarnas added a commit that referenced this issue Jun 21, 2021
Fix (engine): DomConverter.blockElements is missing some of the HTML block element names. Closes #9801. Closes #7863.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant