-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move DLL definition to main CKEditor5 package. #8592
Conversation
@ckeditor/qa-team I'll be working on this a bit more to verify other packages. But for now, could you also verify that it works for you?
It should work OK with all the packages in the sample. |
@pomek please take a look at this as it might invalidate your task about automation. At least in some sort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Suggested merge commit message (convention)
Internal: Move DLL definition to main CKEditor5 package. Closes #8578.
Additional information
This PR adds a meaning to the ckeditor5 package 😉
AFICS this setup works:
ckeditor5
package hassrc
dir with public-public API of base/core CKEditor5 packages as identified in the Implement DLLs for CKEditor 5 features #8517 task. Sockeditor5-core
re-exports are insrc/core.js
file.BasicStyles
package, defines dependency as:ckeditor5: "^23.1.0"
.webpack.dll.config
is simpler now and has only one entry:AFAICS the
yarn install worked
.