Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DLL definition to main CKEditor5 package. #8592

Merged
merged 18 commits into from
Dec 8, 2020
Merged

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Dec 7, 2020

Suggested merge commit message (convention)

Internal: Move DLL definition to main CKEditor5 package. Closes #8578.


Additional information

This PR adds a meaning to the ckeditor5 package 馃槈

AFICS this setup works:

  1. The ckeditor5 package has src dir with public-public API of base/core CKEditor5 packages as identified in the Implement DLLs for CKEditor 5 features聽#8517 task. So ckeditor5-core re-exports are in src/core.js file.
  2. The dependant plugin, verified with BasicStyles package, defines dependency as: ckeditor5: "^23.1.0" .
  3. The webpack.dll.config is simpler now and has only one entry:
new webpack.DllReferencePlugin( {
	manifest: require( '../../build/ckeditor5-dll.manifest.json' ),
	scope: 'ckeditor5/src'
} )

AFAICS the yarn install worked.

@jodator
Copy link
Contributor Author

jodator commented Dec 7, 2020

@ckeditor/qa-team 聽I'll be working on this a bit more to verify other packages. But for now, could you also verify that it works for you?

  1. Please use clean install (no previous node_modules).
  2. Do yarn install as normal.
  3. Run yarn run build:dll task in the main folder.
  4. Run webpack in ckeditor5/sample/plugin folder.
  5. Open the ckeditor5/sample/index.html in the browser.

If the plugins HtmlEmbed and Image fail, please remove them from the sample index.html.

It should work OK with all the packages in the sample.

@jodator jodator requested a review from pomek December 7, 2020 09:04
@jodator
Copy link
Contributor Author

jodator commented Dec 7, 2020

@pomek please take a look at this as it might invalidate your task about automation. At least in some sort.

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit 80790e6 into dll-integration Dec 8, 2020
@pomek pomek deleted the i/8578 branch December 8, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants