You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
domain:dxThis issue reports a developer experience problem or possible improvement.type:taskThis issue reports a chore (non-production change) and other types of "todos".
At this point, I think that we need to validate the last problem, which is - where to expose those paths (questions 2 & 3 in #8517 (comment)). The idea is to add a bigger reason for the ckeditor5 package. It would also make imports a bit more sane, in that term that it would provide imports as:
import{Plugin}from'ckeditor5/core';
At the time of writing this issue, the #8517 issue branch uses ckeditor5-dll to provide DLL build. The imports paths look like below:
This is because we would like to keep the ability to have imports to work the same way as in today's build using direct imports.
This of course requires an entry file in each package that exports public-public API:
// file `core.js` in the `ckeditor5-core` package direclyt (not in /src).export{defaultasPlugin}from'./src/plugin';export{defaultasCommand}from'./src/command';export{defaultasEditor}from'./src/editor/editor';
This is also duplicated by the core.js file inside ckeditor5-dll package:
export*from'@ckeditor/ckeditor5-core/core';
Things to validate when moving those files from ckeditor5-dll to ckeditor5:
Does the DLL is built the same way?
I think that we need to change from where we're importing stuff. So every import form @ckeditor/ckeditor5-feature should be changed to ckeditor5/feature.
Do the yarn/npm workspace handle cyclic import?
We put every package to the ckeditor5/packages but every package might also require one ckeditor5 instead of the current mix of packages (mostly uitls, ui & core).
Do the test, manual tests, and docs works?
I do not consider this as a blocker to the main task, rather as an improvement.
The text was updated successfully, but these errors were encountered:
jodator
added
type:task
This issue reports a chore (non-production change) and other types of "todos".
domain:dx
This issue reports a developer experience problem or possible improvement.
squad:dx
labels
Dec 3, 2020
domain:dxThis issue reports a developer experience problem or possible improvement.type:taskThis issue reports a chore (non-production change) and other types of "todos".
Provide a description of the task
At this point, I think that we need to validate the last problem, which is - where to expose those paths (questions 2 & 3 in #8517 (comment)). The idea is to add a bigger reason for the
ckeditor5
package. It would also make imports a bit more sane, in that term that it would provide imports as:At the time of writing this issue, the #8517 issue branch uses
ckeditor5-dll
to provide DLL build. The imports paths look like below:This is because we would like to keep the ability to have imports to work the same way as in today's build using direct imports.
This of course requires an entry file in each package that exports public-public API:
This is also duplicated by the
core.js
file insideckeditor5-dll
package:Things to validate when moving those files from
ckeditor5-dll
tockeditor5
:@ckeditor/ckeditor5-feature
should be changed tockeditor5/feature
.ckeditor5/packages
but every package might also require oneckeditor5
instead of the current mix of packages (mostlyuitls
,ui
&core
).I do not consider this as a blocker to the main task, rather as an improvement.
The text was updated successfully, but these errors were encountered: