Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar buttons tooltips not visible when editing comment. #347

Closed
mateuszzagorski opened this issue Aug 8, 2022 · 2 comments Β· Fixed by #351
Closed

Toolbar buttons tooltips not visible when editing comment. #347

mateuszzagorski opened this issue Aug 8, 2022 · 2 comments Β· Fixed by #351
Assignees
Labels
bug Something isn't working squad:features
Milestone

Comments

@mateuszzagorski
Copy link
Contributor

mateuszzagorski commented Aug 8, 2022

πŸ“ Provide detailed reproduction steps (if any)

  1. Edit any comment
  2. Hover over one of the buttons inside of the toolbar

βœ”οΈ Expected result

Tooltip is visible.

❌ Actual result

Tooltip is not visible.

❓ Possible solution

It looks like this is caused by the fix we've applied here https://github.com/ckeditor/github-writer/pull/326/files.

πŸ“ƒ Other details

  • Browser: …
  • OS: …

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@FilipTokarski
Copy link
Member

This still happens, but only when you try adding review to a PR.

@Dumluregn
Copy link
Contributor

Thanks @FilipTokarski, I extracted it to #354.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working squad:features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants