Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to std Futures and latest tokio #3

Closed
tyranron opened this issue May 31, 2019 · 3 comments · Fixed by #4
Closed

Upgrading to std Futures and latest tokio #3

tyranron opened this issue May 31, 2019 · 3 comments · Fixed by #4

Comments

@tyranron
Copy link
Contributor

Hi, there! Thank you for this crate 🙇

I'd like to use it extensively, but is it still maintained? The latest change was made at Aug 4 2018 and master depends on tokio-core, which is deprecated long ago.

How about upgrading to the latest tokio and refactoring with std Futures which will come in the nearest 1.36 Rust release? Would you mind on my elaboration on it?
@tyranron tyranron changed the title Upgrading to stable Futures and latest tokio Upgrading to std Futures and latest tokio May 31, 2019
@cksac
Copy link
Owner

cksac commented May 31, 2019

Hi, I do plan to migrate to std Future later

@tyranron
Copy link
Contributor Author

@cksac would you mind if I start the work in a fork+PR and you will review/improve/merge it later when you're ready to migrate to std Future?

@cksac
Copy link
Owner

cksac commented May 31, 2019

@tyranron that will be great :)

@tyranron tyranron mentioned this issue Jun 5, 2019
Merged
5 tasks
@cksac cksac closed this as completed in #4 Jun 5, 2019
@tyranron tyranron mentioned this issue Jun 11, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raw upgrade to std Future
2 participants
@cksac @tyranron