Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year Zero does not exist #177

Closed
daamien opened this issue Apr 13, 2024 · 1 comment
Closed

Year Zero does not exist #177

daamien opened this issue Apr 13, 2024 · 1 comment

Comments

@daamien
Copy link
Contributor

daamien commented Apr 13, 2024

The function faker::chrono::raw::Date(EN).fake() generate date with a year zero (e.g. 0000-04-13)

But there is no such thing :)

https://en.wikipedia.org/wiki/Year_zero#:~:text=Historians%20have%20never%20included%20a,without%20an%20intervening%20year%20zero.

@cksac
Copy link
Owner

cksac commented Apr 25, 2024

I think it will be fine as long as it is a valid Date value and it do exists in some calendar system

However, there is a year zero in both the astronomical year numbering system (where it coincides with the Julian year 1 BC), and the ISO 8601:2004 system

There is also a year zero in most Buddhist and Hindu calendars.

@cksac cksac closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants