Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many files are installed #37

Closed
Comandeer opened this issue Jan 26, 2017 · 3 comments
Closed

Too many files are installed #37

Comandeer opened this issue Jan 26, 2017 · 3 comments
Assignees
Labels
resolution:solved type:enhancement type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Comandeer
Copy link

After installing mgit via npm (npm install mgit2), I've checked out of curiosity the contents of its directory and I saw tests dir, .travis.yml, gulpfile.js etc. These files are needed only for developing mgit, not for using it.

Maybe it could be fine to just whitelist needed file (index.js and lib/ dir) using files field in package.json (npm always include package.json, readme, changelog and license anyway)? Or just blacklist all the files using .npmignore?

@Reinmar Reinmar added status:confirmed type:enhancement type:task This issue reports a chore (non-production change) and other types of "todos". labels Jan 26, 2017
@pomek pomek closed this as completed in 71d2840 Jan 26, 2017
@pomek pomek self-assigned this Jan 26, 2017
@pomek
Copy link
Member

pomek commented Feb 1, 2017

Changes introduced in 71d2840 does not work…

Npm does not install the lib directory.

image

image

@pomek pomek reopened this Feb 1, 2017
@pomek pomek closed this as completed in d6fc7c0 Feb 1, 2017
@pomek
Copy link
Member

pomek commented Feb 1, 2017

Now it should work. I followed package.json in Gulp.

Sorry for the mistake :(

In package.json should be names of files instead of paths.

@pomek
Copy link
Member

pomek commented Feb 1, 2017

It works as I expected in the latest (0.5.1) version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:solved type:enhancement type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

3 participants