Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted release scripts to a new version of ckeditor5-dev-env #102

Merged
merged 4 commits into from
Jul 15, 2019

Conversation

pomek
Copy link
Member

@pomek pomek commented Mar 11, 2019

Suggested merge commit message (convention)

Internal: Adjusted release scripts to a new version of @ckeditor/ckeditor5-dev-env.


Additional information

Requires: ckeditor/ckeditor5-dev#497

@Reinmar
Copy link
Member

Reinmar commented Jul 15, 2019

Is this up to date with ckeditor5-dev? Because this happened:

(t/ckeditor5-dev/496 af7dae2) p@m /workspace/misc/mgit2> npm run release:bump-version

> mgit2@0.10.1 release:bump-version /workspace/misc/mgit2
> node ./scripts/bump-version.js

path.js:39
    throw new ERR_INVALID_ARG_TYPE('path', 'string', path);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
    at assertPath (path.js:39:11)
    at Object.join (path.js:1155:7)
    at getSubRepositoriesPaths (/workspace/misc/mgit2/node_modules/@ckeditor/ckeditor5-dev-env/lib/release-tools/utils/getsubrepositoriespaths.js:31:28)
    at bumpVersions (/workspace/misc/mgit2/node_modules/@ckeditor/ckeditor5-dev-env/lib/release-tools/tasks/bumpversions.js:46:26)
    at Object.bumpVersions (/workspace/misc/mgit2/node_modules/@ckeditor/ckeditor5-dev-env/lib/index.js:18:57)
    at Object.<anonymous> (/workspace/misc/mgit2/scripts/bump-version.js:11:3)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! mgit2@0.10.1 release:bump-version: `node ./scripts/bump-version.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the mgit2@0.10.1 release:bump-version script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/p/.npm/_logs/2019-07-15T13_37_50_763Z-debug.log

But I wasn't executing this on master, so I dunno if that's not causing this error.

@coveralls
Copy link

coveralls commented Jul 15, 2019

Pull Request Test Coverage Report for Build 332

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.251%

Totals Coverage Status
Change from base Build 326: 0.0%
Covered Lines: 504
Relevant Lines: 504

💛 - Coveralls

@Reinmar
Copy link
Member

Reinmar commented Jul 15, 2019

Oh, this PR is blocked by ckeditor/ckeditor5-dev#497. Sorry, didn't notice that.

@Reinmar Reinmar merged commit b519688 into master Jul 15, 2019
@Reinmar Reinmar deleted the t/ckeditor5-dev/496 branch July 15, 2019 14:35
@Reinmar Reinmar mentioned this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants