New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adam updates #77

Closed

rasoolims opened this issue Sep 15, 2016 · 1 comment

Labels

rasoolims commented Sep 15, 2016

Hi,

I see a small difference in Adam update from the original algorithm in the paper. Here you increment variable t per parameter update while I think it should be per update round.
https://github.com/rasoolims/cnn/blob/master/cnn/training.cc#L266

Contributor

neubig commented Sep 18, 2016

This has been fixed in the v2 branch, I'd suggest transitioning to the v2 branch.

neubig added the to be merged label

neubig closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment