Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavelength change seems not to change power #13

Open
peakflyer opened this issue Jun 15, 2021 · 10 comments
Open

Wavelength change seems not to change power #13

peakflyer opened this issue Jun 15, 2021 · 10 comments

Comments

@peakflyer
Copy link

When I use powermeter.sense.correction.wavelength = 1550 or 800 the obtained optical power from powermeter.read does not change while it does change on the powermeter software from thorlabs. Is this a bug? powermeter.sense.correction.max_wavelength works fine for example.

@clade
Copy link
Owner

clade commented Jun 15, 2021

Thank you for pointing out this bug. On need to add the unit to the sting send to the instrument.
I think it is now corrected on commit ce651cd (dev branch)

I don't have a powermeter on hand to test. Could you test it ?

@peakflyer
Copy link
Author

I tested it but the problem is still there.

@peakflyer
Copy link
Author

The beamdiameter also won't change but changing the average count works fine for me.

@clade
Copy link
Owner

clade commented Jun 16, 2021

I initially tought that Thorlabs requires the unit when the command is send.
I manage to do some test on a PM100A. The wavelength is not changed when the required wavelength in not in the range of the sensor.

The commit d77ad7d add an automatic test for the wavelength. It works on my device.

Now the command :
power_meter.sense.correction.wavelength = 780
works. But the command :
power_meter.sense.correction.wavelength = 10
raises an Exception.

@peakflyer
Copy link
Author

I am testing it on the PM101. The commands in the manual are the same on first sight. I have a sensor with wavelength range of 800-1700 nm but power_meter.sense.correction.wavelength = 1310 f.e. doesn't work.

@peakflyer
Copy link
Author

OK on the Thorlabs PM100D everything works fine. The only thing that is not clear for me is how to change the configuration from CURR to POW.

@clade
Copy link
Owner

clade commented Jun 16, 2021

This is a different question. I think that :
powermeter.configure.scalar.current.dc()
powermeter.configure.scalar.power()
will change the setting of powermeter.read

@clade
Copy link
Owner

clade commented Jun 16, 2021

I am testing it on the PM101. The commands in the manual are the same on first sight. I have a sensor with wavelength range of 800-1700 nm but power_meter.sense.correction.wavelength = 1310 f.e. doesn't work.

According to the datasheet, it should work with the PM101.
What is the result of power_meter.sense.correction.minimum_wavelength

@peakflyer
Copy link
Author

The result is 800. I already contacted the Thorlabs tech support. Let's see what they say about it.

@peakflyer
Copy link
Author

I now figured out what caused the problem. In the wavelength class it says:
value = Argument(0, ["MINimum", "MAXimum", "<numeric_value>nm"])
The unit has to be removed as in the following line:
value = Argument(0, ["MINimum", "MAXimum", "<numeric_value>"])

Interestingly on the PM100D its working perfectly fine with and without the unit whereas on the PM101 it only works without the unit. Therefore I think the unit should be removed on every setter command. That is also what the Throlabs technical support told me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants