GitHub webhook sometimes gets an HTTP 504 Gateway Timeout from CLAHub

[jasonm]

I'm trying to verify the CLAHub setup for Molajo/Filesystem - specifically, Molajo/Filesystem#2. That project is using TravisCI, so #27 still applies here and we'll currently only see one status indicator at a time (Travis or CLAHub) for a given pull.

That said, I can see via API access that CLAHub never correctly set a status on Molajo/Filesystem@3636c37 for Molajo/Filesystem#2.

In fact, when GitHub sent a Webhook to CLAHub, CLAHub responded with a 504 Gateway Timeout:

irb(main):008:0> pp g.repos.hooks.find('Molajo', 'Filesystem', a.github_repo_hook_id)
{"url"=>"https://api.github.com/repos/Molajo/Filesystem/hooks/ID_REDACTED",
 "test_url"=>
  "https://api.github.com/repos/Molajo/Filesystem/hooks/ID_REDACTED/test",
 "id"=>ID_REDACTED,
 "name"=>"web",
 "active"=>true,
 "events"=>["push"],
 "config"=>{"url"=>"http://www.clahub.com/repo_hook"},
 "last_response"=>{"code"=>504, "status"=>"timeout", "message"=>""},
 "updated_at"=>"2013-02-17T08:47:45Z",
 "created_at"=>"2013-02-06T06:33:13Z"}

It could have been that CLAHub was running on a single Heroku Dyno and did not spin up in time, or that the processing simply took too long.

Ideally GitHub webhooks would retry if given a non-2xx response. Absent that, we should ensure CLAHub always has at least 1 dyno. Since Heroku also imposes a 30-second limit on response time, we likely also want to background all webhook responses, similar to #1.

[jasonm]

I've inquired with GitHub support about webhook retries.

[jasonm]

@AmyStephen if you get a moment, could you do me a favor and try going to Molajo/Filesystem settings > Service Hooks > WebHook URLs and clicking "Test Hook"?

And then see if Molajo/Filesystem#2 gets a CLAHub status? It might not right away (because of TravisCI maybe overwriting it), but I'm curious for you to try it. Thanks!

[AmyStephen]

Doesn't appear to be updating.

If it helps for testing, I can make you an Admin of the repository.

[damtur]

I've inquired with GitHub support about webhook retries.

@jasonm Can you please add a link to that