Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable fields per CLA #5

Closed
jasonm opened this issue Jan 9, 2013 · 9 comments
Closed

Allow configurable fields per CLA #5

jasonm opened this issue Jan 9, 2013 · 9 comments
Assignees

Comments

@jasonm
Copy link
Member

jasonm commented Jan 9, 2013

What should we record upon signature to make the signature more legally defensible? IP address and time? Should the contributor re-type their name or initials? Anything else?

We shall allow agreement authors to include one or more predefined fields:

Implicit

  • GitHub username
  • Date

Default to: include on new CLAs, but allow opt-out

  • Email
  • Name
  • Mailing address
  • Country
  • Phone or Skype
  • Type "I AGREE"
  • Corporate Contributor Information

Default to: exclude from new CLAs, but allow opt-in

  • Type your initials
@jasonm
Copy link
Member Author

jasonm commented Jan 19, 2013

Not sure if "bug" or "enhancement" but if these aren't legally defensible then it's not a valuable product 😄

@fusion94
Copy link
Member

@jasonm we should record a few datapoints.

It looks at though we already collect from GH the uid, nickname, email, and name.

I'd add additional fields for mailing address and country as well as a confirmation field that requires them to type their name which should match up with their github name.

@jasonm
Copy link
Member Author

jasonm commented Jan 23, 2013

That sounds good. I'm curious what people typically collect electronically. Looks like exactly what you recommend here.

Tangentially, I've started a list of existing CLAs we can use as reference: https://github.com/jasonm/clahub/wiki/Existing-CLAs

@jasonm
Copy link
Member Author

jasonm commented Jan 23, 2013

One note is that, while we attempt to fetch email via GH API, not all GH users populate this. Hence #18

@isaacs
Copy link

isaacs commented Jan 25, 2013

Ideally, it would be up to the project maintainer to add whatever fields they need. As much as I'd love to go back in time and change it around so that only a single button-click is necessary, I don't look forward to haggling with lawyers over this ever again. It'd be best to be able to have the same exact form fields and language as our existing CLA.

@jasonm
Copy link
Member Author

jasonm commented Feb 18, 2013

wip on branch jm-agreement-fields:

Adding fields:
CLAHub-1

Signature and validation:
CLAHub

@jasonm
Copy link
Member Author

jasonm commented Feb 18, 2013

This is landed on production now.

@jasonm
Copy link
Member Author

jasonm commented Feb 18, 2013

Still need to fix #10 so that existing agreement authors may add these fields to existing agreements.

@jasonm
Copy link
Member Author

jasonm commented Feb 18, 2013

With 5991214 these additional fields are now also included in the CSV download:

clahub-contributor-agreement-signatures-20130218-001053

@jasonm jasonm closed this as completed Feb 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants