Allow configurable fields per CLA

[jasonm]

What should we record upon signature to make the signature more legally defensible? IP address and time? Should the contributor re-type their name or initials? Anything else?

We shall allow agreement authors to include one or more predefined fields:

Implicit

• GitHub username
• Date

Default to: include on new CLAs, but allow opt-out

• Email
• Name
• Mailing address
• Country
• Phone or Skype
• Type "I AGREE"
• Corporate Contributor Information

Default to: exclude from new CLAs, but allow opt-in

• Type your initials

[jasonm]

Not sure if "bug" or "enhancement" but if these aren't legally defensible then it's not a valuable product 😄

[fusion94]

@jasonm we should record a few datapoints.

It looks at though we already collect from GH the uid, nickname, email, and name.

I'd add additional fields for mailing address and country as well as a confirmation field that requires them to type their name which should match up with their github name.

[jasonm]

That sounds good. I'm curious what people typically collect electronically. Looks like exactly what you recommend here.

Tangentially, I've started a list of existing CLAs we can use as reference: https://github.com/jasonm/clahub/wiki/Existing-CLAs

[jasonm]

One note is that, while we attempt to fetch email via GH API, not all GH users populate this. Hence #18

[isaacs]

Ideally, it would be up to the project maintainer to add whatever fields they need. As much as I'd love to go back in time and change it around so that only a single button-click is necessary, I don't look forward to haggling with lawyers over this ever again. It'd be best to be able to have the same exact form fields and language as our existing CLA.

[jasonm]

wip on branch jm-agreement-fields:

Adding fields:

Signature and validation:

[jasonm]

This is landed on production now.

[jasonm]

Still need to fix #10 so that existing agreement authors may add these fields to existing agreements.

[jasonm]

With 5991214 these additional fields are now also included in the CSV download: