CI: use sudo, assume docker present, use diff-{quality,cover} #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamWill
force-pushed
the
ci-fixes
branch
3 times, most recently
from
c39bb11
to
8bbad83
Compare
AdamWill
force-pushed
the
ci-fixes
branch
2 times, most recently
from
9d81a0e
to
7f8cd5c
Compare
Huh. I kinda just assumed we'd be root. Guess not! Docker is already in the GHA base image, no need to install. Both linter tools report issues on the current master branch, which means they will always fail on exit. Using diff-quality gives us a check we can usefully fail on (as configured in this PR, it will only fail if the quality of the lines changed in the PR is less than 9.0). Similarly we can generate a coverage report and use diff-cover to fail if coverage of the PR is under 90%. This also uses a standard configuration file name for the pylint config (so we don't have to specify it with `--rcfile`), removes all non-default settings from the pylint config so it's clearer what we really intend to configure, and moves the flake8 config to a config file like pylint. We don't use pyproject.toml for configuration here because GHA's Ubuntu environment is just not new enough, the tools in it don't consistently read from pyproject.toml. Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill
force-pushed
the
ci-fixes
branch
2 times, most recently
from
efb103b
to
927cc89
Compare
|
OK, this looks to be working. I can't manage to get it to give us diff-quality for the oz-* scripts, which is unfortunate, but it works for everything inside the oz module at least, which is an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huh. I kinda just assumed we'd be root. Guess not!
All my attempts to just get a 'docker' binary installed seem to be failing on conflicts. Maybe it's already there in the GHA image? Let's try leaving it out.
Both linter tools report issues on the current master branch, which means they will always fail on exit. Using diff-quality gives us a check we can usefully fail on (as configured in this PR, it will only fail if the quality of the lines changed in the PR is less than 9.0).
Similarly we can use diff-cover to fail if coverage of the PR is under 90%.
This also uses a standard configuration file name for the pylint config (so we don't have to specify it with
--rcfile), removes all non-default settings from the pylint config so it's clearer what we really intend to configure, and moves the flake8 config to a config file like pylint.