Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tell/remind] Add warning when trying to tell/remind someone many thing #29

Open
Clam- opened this issue Nov 17, 2014 · 5 comments
Open

[tell/remind] Add warning when trying to tell/remind someone many thing #29

Clam- opened this issue Nov 17, 2014 · 5 comments
Labels
Discussion Enhancement

Comments

@Clam-
Copy link
Owner

Clam- commented Nov 17, 2014

I guess need to query for undelivered items and count. Should be trivial.
@Clam- Clam- changed the title Add warning when trying to tell/remind someone many thing [tell/remind] Add warning when trying to tell/remind someone many thing Nov 17, 2014
@Clam-
Copy link
Owner Author

Clam- commented Nov 18, 2014

Do we actually want this? I've put the query in the code commented out, but it seems kinda... useless?
If you think otherwise you just need to uncomment the code and then throw on some extra text in the conditional. I also think it might be slow query...

Clam- added a commit that referenced this issue Nov 18, 2014
@Clam-
Fixed bugs, changed functionality:
2c6640b 
* Fixed docstrigns for calc
* Fixed handling of calc error
* Changed strins of assembleMsgWLen to use .format instead of % for string
  interpolation, which means changed modules to use {0}etc instead of %s
* Changed strins of assembleMsgWLen so that is requires a list for
  manipulating. Also changed modules that used this to use lists
* Fixed missing import in tell for dpasting
* Added checking for self in tell and remind
* Added code for #29 but commented it out
* Changed bot to not blindly truncate lines because that's bads
* Fixed bot's trimming of unicode data/maximum msg size
* Used a little bit saner implementation of assembleMsgWLen which changed
  splitEncodedUnicode to return encoded trimmed string size. Fixes #28
* Hardcoded a "granularity" in distance_of_time_in_words
* Fixed bug in settings which would dump list with None in it
* Fixed bug in settings where old server wouldn't be removed when config
  changed. Fixes #31
@gkistler
Copy link
Collaborator

Not a big deal if it's a slow query since it'll just be on tell, but I agree that it seems kinda useless.

The message existed in oldbbm because oldbbm did fire and forget with the tells when pastebinning them, so it would be better to focus our attention on ensuring the delivery of tells instead of warning that they might get lost.

@Clam-
Copy link
Owner Author

Clam- commented Nov 19, 2014

This may be important after all since current bot will fire and forget pastehelper.
Do we want to continue using pastebins for tells and stuff? Or do we want overflows to go to notices and such? (I think people like spying on tells and stuff. I know I do if I'm bored.)

@gkistler
Copy link
Collaborator

gkistler commented May 1, 2016

I'm thinking the best bet is to modify the database to indicate delivery after either bot.say() or pastehelper() finishes successfully; I'm giving this a try in pbm_alert.py and will implement in tell if it's coo'.

@Clam-
Copy link
Owner Author

Clam- commented May 1, 2016

That would be useful to rewire the logic to update the DB after paste finishes.
I update the DB in the same request as getting the tells (batch) so that no weird timing double tell issues occur but maybe that can be reworked, or undoing the update on failure.
https://github.com/Clam-/pyBurlyBot/blob/master/modules/pbm_tell.py#L105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Clam- @gkistler