Add integration with cmake-tools extension #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr-tream
force-pushed
the
cmake-tools-integration
branch
from
455cb0a
to
cc21699
Compare
|
In force-push, added missed field in |
sr-tream
force-pushed
the
cmake-tools-integration
branch
2 times, most recently
from
0e54e6d
to
fa46e7b
Compare
sr-tream
force-pushed
the
cmake-tools-integration
branch
from
fa46e7b
to
bf81862
Compare
This picks up version 0.1.17 of @clangd/install
…iate. (#398) As recommended in microsoft/vscode#78806 This is an incomplete fix but better than nothing. Also files microsoft/vscode#164310 in case VSCode can improve the behavior here. fixes #390
The intention was to only catch the case where the language server is already starting because running the restart command triggered activation of the plugin, but it was also catching the case where the language server wasn't running at all. Fixes #599
|
Feature implemented in extension, with provided API (#575) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add integration with cmake-tools extension. It uses exported API instead of querying the extension instance directly, so this integration must work with any cmake-tools forks, that implement this API.
This PR is cannot use as a complete replacement for
.clangdconfigure file - it not pass--query-driverto clangd because clangd doesn't support change this via LSP. So this PR just alternative to export compile commands (clangd in VSCode now may work with--compile_args_from=lspflag).Resolves #233, #498