Skip to content
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.

Background issues while using colorRipple #15

Closed
adek opened this issue Apr 8, 2015 · 6 comments
Closed

Background issues while using colorRipple #15

adek opened this issue Apr 8, 2015 · 6 comments
Labels

Comments

@adek
Copy link

adek commented Apr 8, 2015

Background issues while using custom pressed and ripple colors.

This is my FAB layout:
<com.github.clans.fab.FloatingActionButton
android:id="@+id/fab"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="bottom|right"
android:layout_margin="16dp"
android:src="@drawable/ic_add_white_24dp"
fab:fab_colorNormal="@color/theme_accent"
fab:fab_colorPressed="@color/theme_accent_pressed"
fab:fab_colorRipple="@color/theme_accent_ripple" />

issue-fab1

Tested on Nexus 6 (Android 5.1).

When I remove colorPressed and colorRipple strange rectangles are gone.

@adek adek changed the title Background issues while using colorRipple/colorPressed Background issues while using colorRipple Apr 8, 2015
@Clans Clans added the bug label Apr 8, 2015
@Kennyc1012
Copy link

I have had users also report this issue, however I only have the colorNormal and colorPressed set, not colorRipple. Here is the layout file containing the buttons, the FloatingActionMenu is the button which is showing the rectangles

@Clans
Copy link
Owner

Clans commented Apr 12, 2015

Working on it. Will try to publish a fix as soon as I'll have some free time.

@adek
Copy link
Author

adek commented Apr 13, 2015

Yes. I thought that removing colorRipple fixed the problem but it wasn't fixed.
The problem is visible on Android 5+ devices. On my old Android with 4.4 button and focus looks good.

@tbolender
Copy link

Can also confirm it on Android 5.1 (Nexus 5).

@adek
Copy link
Author

adek commented Apr 13, 2015

Does anyone have workaround for this bug?
I'm trying to find what's going on. It looks like this is only Android 5.1 (API22) bug. On my Genymotion device Android 5.0 (API21) it looks fine, ripple effect is also OK.

This is somehow connected to focus (not the ripple effect).

@Clans
Copy link
Owner

Clans commented Apr 14, 2015

It's finally here! See the Changelog for new awesome improvements and bug fixes.

@Clans Clans closed this as completed Apr 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants