-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate App::with_defaults() #692
Deprecate App::with_defaults() #692
Conversation
@@ -98,6 +98,7 @@ impl<'a, 'b> App<'a, 'b> { | |||
/// [`crate_version!`]: ./macro.crate_version!.html | |||
/// [`App::author`]: ./struct.App.html#method.author | |||
/// [`App::version`]: ./struct.App.html#method.author | |||
#[deprecated(since="2.14.1", note="Can never work; use explicit App::author() and App::version() calls instead")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite sure which version should be put here, as it should be the next released one (which is either gonna be 2.14.1 or 2.15.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of right now the next one will be 2.14.1 so we're good here!
Is @homu dead? |
@homu r+ |
📌 Commit 2608540 has been approved by |
…te, r=kbknapp Deprecate App::with_defaults() Closes #638
…te, r=kbknapp Deprecate App::with_defaults() Closes #638
Doesn't look like it? |
☀️ Test successful - status |
It seemed so for a while |
Closes #638