Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add embed (excalidraw, youtube...) #61

Closed
alxlion opened this issue Oct 15, 2023 · 18 comments
Closed

[Feature] Add embed (excalidraw, youtube...) #61

alxlion opened this issue Oct 15, 2023 · 18 comments
Labels
💎 Bounty enhancement New feature or request 💰 Rewarded roadmap Planned for the next release

Comments

@alxlion
Copy link
Contributor

alxlion commented Oct 15, 2023

Description

Add an "Embed" interaction on a slide like a Youtube video or any website with an iframe.

Specs

You can take inspiration from other interactions like Polls or Forms.

Front

Presenter

When an embed is enabled and is in the current slide position, show it in full screen.

Manager

When clicking on "Add interraction", add this option to the popup:

CleanShot 2023-10-20 at 11 29 16

Use this icon:

<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke-width="1.5" stroke="currentColor" class="w-6 h-6">
  <path stroke-linecap="round" stroke-linejoin="round" d="M14.25 9.75L16.5 12l-2.25 2.25m-4.5 0L7.5 12l2.25-2.25M6 20.25h12A2.25 2.25 0 0020.25 18V6A2.25 2.25 0 0018 3.75H6A2.25 2.25 0 003.75 6v12A2.25 2.25 0 006 20.25z" />
</svg>

When selecting "Embed", show a form with fields title and content (get your inspirations from other interactions like Polls and Forms).

The content field is a textarea and the user has to fill it with an iframe. (<iframe></iframe>)

When added, you can enable it (like any other interactions). Do not forget: By enabling an interaction, you have to disable the others (only one enabled interaction by slide).

Report (when event is ended)

Display embed, if present, on the current slide in the report.

CleanShot 2023-10-20 at 11 44 54

Back

When an Embed is added, broadcast it to all (presenter + manager + attendees). Like I said before, take your inspiration from other interactions like Forms or Polls.

When an Embed is enabled, disable any other interaction on the current slide.

Database

Add a table embeds with columns title (string), content (string), position (int), presentation_file_id (int / foreign key), enabled (bool), inserted_at (timestamp), updated_at (timestamp).

@alxlion alxlion added enhancement New feature or request roadmap Planned for the next release labels Oct 15, 2023
@alxlion
Copy link
Contributor Author

alxlion commented Oct 19, 2023

/bounty 300

@algora-pbc
Copy link

algora-pbc bot commented Oct 19, 2023

💎 $300 bounty created by alxlion
🙋 If you start working on this, comment /attempt #61 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #61 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to ClaperCo/Claper!

Attempt Started (GMT+0) Solution
🟢 @Usama4745 Oct 20, 2023, 10:31:03 AM WIP
🟢 @Dhanus3133 Oct 30, 2023, 8:42:08 PM #72

@Usama4745
Copy link

Hey @alxlion can you explain it little bit more what needs to be done?
What I understood is that we need to define iframe somewhere where we can add youtube videos?

@alxlion
Copy link
Contributor Author

alxlion commented Oct 20, 2023

@Usama4745 Sorry, I forgot the specs. I edited the first message. I hope it's enough for you, do no hesitate if you have questions and if you have some ideas/improvement to the original specs.

Thanks 🙏

@Usama4745
Copy link

Usama4745 commented Oct 20, 2023

@alxlion thanks for feedback. I will start working on it
/attempt #61

Options

@Usama4745
Copy link

facing this error while running

mix ecto.migrate

** (RuntimeError) SECRET_KEY_BASE configuration option is required. See https://docs.claper.co/configuration.html#production-docker (stdlib 3.17) erl_eval.erl:685: :erl_eval.do_apply/6 (elixir 1.12.2) lib/code.ex:656: Code.eval_string_with_error_handling/3 (elixir 1.12.2) lib/config.ex:258: Config.__eval__!/3 (elixir 1.12.2) lib/config/reader.ex:86: Config.Reader.read!/2 (mix 1.12.2) lib/mix/tasks/loadconfig.ex:57: Mix.Tasks.Loadconfig.load_runtime/1 (mix 1.12.2) lib/mix/tasks/app.config.ex:38: Mix.Tasks.App.Config.run/1

@alxlion can you confirm where do we need to add SECRET_KEY_BASE variable for this issue

@alxlion
Copy link
Contributor Author

alxlion commented Oct 24, 2023

facing this error while running

mix ecto.migrate

`** (RuntimeError) SECRET_KEY_BASE configuration option is required. See https://docs.claper.co/configuration.html#production-docker

(stdlib 3.17) erl_eval.erl:685: :erl_eval.do_apply/6

(elixir 1.12.2) lib/code.ex:656: Code.eval_string_with_error_handling/3

(elixir 1.12.2) lib/config.ex:258: Config.__eval__!/3

(elixir 1.12.2) lib/config/reader.ex:86: Config.Reader.read!/2

(mix 1.12.2) lib/mix/tasks/loadconfig.ex:57: Mix.Tasks.Loadconfig.load_runtime/1

(mix 1.12.2) lib/mix/tasks/app.config.ex:38: Mix.Tasks.App.Config.run/1`

@alxlion can you confirm where do we need to add SECRET_KEY_BASE variable for this issue

Yes, it is on the documentation : https://docs.claper.co/configuration.html#production-docker

@haruncurak
Copy link
Contributor

Hi @Usama4745 are you still working on this? Happy to help out or take over for this task if you're facing some issues.

@Usama4745
Copy link

hey @haruncurak I am still not able to setup project. while using docker image getting issue of folder not getting created for presentation file.

@alxlion
Copy link
Contributor Author

alxlion commented Oct 27, 2023

hey @haruncurak I am still not able to setup project. while using docker image getting issue of folder not getting created for presentation file.

Docker is used for deployment, it is not suited for development. It's better to have elixir installed on your computer and a db in Docker for example.

@Usama4745
Copy link

hey @haruncurak I am still not able to setup project. while using docker image getting issue of folder not getting created for presentation file.

Docker is used for deployment, it is not suited for development. It's better to have elixir installed on your computer and a db in Docker for example.

I was facing multiple issues while installing in my windows system now I have installed WSL and trying on it

@Usama4745
Copy link

Hey @alxlion I have duplicated .env from .env.sample and added SECRET_KEY_BASE mix phx.gen.secret command but I am still facing this issue while running mix ecto.migrate can you confirm what needs to be done here?

** (RuntimeError) SECRET_KEY_BASE configuration option is required. See https://docs.claper.co/configuration.html#production-docker (stdlib 3.17) erl_eval.erl:685: :erl_eval.do_apply/6 (elixir 1.12.2) lib/code.ex:656: Code.eval_string_with_error_handling/3 (elixir 1.12.2) lib/config.ex:258: Config.__eval__!/3 (elixir 1.12.2) lib/config/reader.ex:86: Config.Reader.read!/2 (mix 1.12.2) lib/mix/tasks/loadconfig.ex:57: Mix.Tasks.Loadconfig.load_runtime/1 (mix 1.12.2) lib/mix/tasks/app.config.ex:38: Mix.Tasks.App.Config.run/1

@Usama4745
Copy link

Hey @alxlion I have duplicated .env from .env.sample and added SECRET_KEY_BASE mix phx.gen.secret command but I am still facing this issue while running mix ecto.migrate can you confirm what needs to be done here?

** (RuntimeError) SECRET_KEY_BASE configuration option is required. See https://docs.claper.co/configuration.html#production-docker (stdlib 3.17) erl_eval.erl:685: :erl_eval.do_apply/6 (elixir 1.12.2) lib/code.ex:656: Code.eval_string_with_error_handling/3 (elixir 1.12.2) lib/config.ex:258: Config.__eval__!/3 (elixir 1.12.2) lib/config/reader.ex:86: Config.Reader.read!/2 (mix 1.12.2) lib/mix/tasks/loadconfig.ex:57: Mix.Tasks.Loadconfig.load_runtime/1 (mix 1.12.2) lib/mix/tasks/app.config.ex:38: Mix.Tasks.App.Config.run/1

Well I have just resolve the issue by adding correct value for secret key inside config/runtime.exs file

@Dhanus3133
Copy link
Contributor

Dhanus3133 commented Oct 30, 2023

/attempt #61

Options

@algora-pbc
Copy link

algora-pbc bot commented Oct 30, 2023

Note: The user @Usama4745 is already attempting to complete issue #61 and claim the bounty. If you attempt to complete the same issue, there is a chance that @Usama4745 will complete the issue first, and be awarded the bounty. We recommend discussing with @Usama4745 and potentially collaborating on the same solution versus creating an alternate solution.

@algora-pbc
Copy link

algora-pbc bot commented Oct 31, 2023

💡 @Dhanus3133 submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

alxlion pushed a commit that referenced this issue Nov 23, 2023
@alxlion
Copy link
Contributor Author

alxlion commented Nov 23, 2023

Merged ! Will be on the next release.

@alxlion alxlion closed this as completed Nov 23, 2023
Copy link

algora-pbc bot commented Nov 23, 2023

🎉🎈 @Dhanus3133 has been awarded $300! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty enhancement New feature or request 💰 Rewarded roadmap Planned for the next release
Projects
Status: Done
Development

No branches or pull requests

4 participants