Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Live" icon is gone in 0.2.24 when using clappr-level-selector #727

Closed
ariselseng opened this issue Dec 10, 2015 · 11 comments
Closed

"Live" icon is gone in 0.2.24 when using clappr-level-selector #727

ariselseng opened this issue Dec 10, 2015 · 11 comments
Labels

Comments

@ariselseng
Copy link
Contributor

<script src="https://cdn.jsdelivr.net/clappr/0.2.24/clappr.min.js"></script>
<script src="https://cdn.jsdelivr.net/clappr.level-selector/0.1.3/level-selector.min.js"></script>

With these versions The live icon to the right of the play/pause button is gone when I activate clappr-level-selector.

I need to back to Clappr 0.2.23 and level selector 0.1.1 to have a working setup.

@leandromoreira
Copy link
Member

what playback are you using? (mp4, hls, rtmp ...) and browser too? also, it'd better if you open this on level-selector project :P

@ariselseng
Copy link
Contributor Author

Live HLS, google chrome browser in linux.
Same in Firefox in linux.

@me-vlad
Copy link
Contributor

me-vlad commented Dec 11, 2015

@cowai can you provide a test stream url?
Live indicator works with Clappr 0.2.24 + level-selector 0.1.3 in Google Chrome 47.0.2526.80 (64-bit), fedora 23

@gfronza
Copy link

gfronza commented Dec 19, 2015

It works for me (with both rtmp and hls) using the latest versions of clappr (0.2.28) and level-selector (0.1.6).

@ariselseng
Copy link
Contributor Author

@gfronza Could you provide with a working example?
0.2.28 and 0.1.6 doesn't work at all for me. I mean clappr doesn't load because of errors.
In the console in chrome:
Uncaught TypeError: Cannot read property '_listenId' of undefined
Uncaught TypeError: Cannot read property 'settings' of null

Test link: https://rawgit.com/cowai/48bf5cd022e05ccb0d99/raw/9f6b36ce30cf8784d091e358c6defe7704d1707d/clappr-levelselector-error.html

@ariselseng
Copy link
Contributor Author

@gfronza
Copy link

gfronza commented Dec 21, 2015

@cowai the dist files were not updated in the last release of level-selector. It was working for me because I had compiled a version for debugging.

@leandromoreira I'll open an issue on https://github.com/clappr/clappr-level-selector-plugin

@gfronza
Copy link

gfronza commented Dec 21, 2015

@cowai there's a new version of level-selector plugin with the updated dist files. Can you try again please?

@ariselseng
Copy link
Contributor Author

http://rawgit.com/cowai/b14e3825604c6e612120/raw/2ce3d9d64f0b03116531b618865c65e701cbce23/clappr-live-icon-with-dvr-and-levelselector-test.html

Now it works a little better. There seem to be a race condition problem. I now get the live icon when I go back in the dvr buffer, but not at initial load.

There is also loading bar on top of the playing stream in Firefox although the video has loaded fine. This does not happen in chrome. Both using hlsjs.

@gfronza
Copy link

gfronza commented Dec 22, 2015

@cowai I see, we should definitely track this issue in clappr-level-selector-plugin. Can you open a new issue there? I'll start looking into it now though. If that's ok with you, this issue here at clappr/clappr can be closed.

In Firefox 43.0.1 (for OS X) I wasn't able to play your video. Actually the video starts playing, but after a few seconds it goes all black. This problem with the loading bar on top of the video was already addressed in the release 0.2.27 of Clappr. Are you sure you have the latest version? Anyway, you can report this in a separate issue.

@ariselseng
Copy link
Contributor Author

@gfronza Sorry for late response. My firefox has not yet auto-updated to 43 yet (on OS X), but in in 42 the stream works perfectly.

This issue can be closed yes. Thank you and merry christmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants